You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by ni...@apache.org on 2018/08/06 02:09:48 UTC

[incubator-servicecomb-saga] 02/02: SCB-784 Fixed the acceptance test error

This is an automated email from the ASF dual-hosted git repository.

ningjiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-servicecomb-saga.git

commit 679399d43dc77f2604aba74da5c8fd541a691023
Author: Willem Jiang <ji...@huawei.com>
AuthorDate: Mon Jul 30 11:23:32 2018 +0800

    SCB-784 Fixed the acceptance test error
---
 .../src/test/java/org/apache/servicecomb/saga/PackStepdefs.java     | 6 +++++-
 .../src/test/resources/pack_compensation_scenario.feature           | 4 ++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/acceptance-tests/acceptance-pack-spring-demo/src/test/java/org/apache/servicecomb/saga/PackStepdefs.java b/acceptance-tests/acceptance-pack-spring-demo/src/test/java/org/apache/servicecomb/saga/PackStepdefs.java
index 5488f0c..19651e7 100644
--- a/acceptance-tests/acceptance-pack-spring-demo/src/test/java/org/apache/servicecomb/saga/PackStepdefs.java
+++ b/acceptance-tests/acceptance-pack-spring-demo/src/test/java/org/apache/servicecomb/saga/PackStepdefs.java
@@ -148,7 +148,11 @@ public class PackStepdefs implements En {
     await().atMost(5, SECONDS).until(() -> {
       actualMaps.clear();
       Collections.addAll(actualMaps, retrieveDataMaps(address, dataProcessor));
-
+      // write the log if the Map size is not same
+      boolean result = expectedMaps.size() == actualMaps.size();
+      if (!result) {
+        LOG.warn("The response message size is not we expected. ExpectedMap size is {},  ActualMap size is {}", expectedMaps.size(), actualMaps.size());
+      }
       return expectedMaps.size() == actualMaps.size();
     });
 
diff --git a/acceptance-tests/acceptance-pack-spring-demo/src/test/resources/pack_compensation_scenario.feature b/acceptance-tests/acceptance-pack-spring-demo/src/test/resources/pack_compensation_scenario.feature
index 931d316..b88db29 100644
--- a/acceptance-tests/acceptance-pack-spring-demo/src/test/resources/pack_compensation_scenario.feature
+++ b/acceptance-tests/acceptance-pack-spring-demo/src/test/resources/pack_compensation_scenario.feature
@@ -32,8 +32,8 @@ Feature: Alpha records transaction events
       | hotel   | TxAbortedEvent     |
       | booking | TxAbortedEvent     |
       | car     | TxCompensatedEvent |
-     
-
+      | car     | SagaEndedEvent     |
+    
     Then Car Service contains the following booking orders
       | name | amount | confirmed | cancelled |
       | Sean | 5      | false     | true      |