You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Grant Monroe <gr...@tnarg.com> on 2014/09/02 22:23:54 UTC
Re: Review Request 25160: Major throughput improvement with mixed
workloads
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25160/#review52074
-----------------------------------------------------------
./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java
<https://reviews.apache.org/r/25160/#comment90808>
what if request is null?
- Grant Monroe
On Aug. 28, 2014, 6:27 p.m., Kfir Lev-Ari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25160/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2014, 6:27 p.m.)
>
>
> Review request for zookeeper, Raul Gutierrez Segales and Alexander Shraer.
>
>
> Repository: zookeeper
>
>
> Description
> -------
>
> Please see https://issues.apache.org/jira/browse/ZOOKEEPER-2024
>
>
> Diffs
> -----
>
> ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1619360
> ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java 1619360
> ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 1619360
>
> Diff: https://reviews.apache.org/r/25160/diff/
>
>
> Testing
> -------
>
> The attached unit tests, as well as the system test found in https://issues.apache.org/jira/browse/ZOOKEEPER-2023.
>
>
> Thanks,
>
> Kfir Lev-Ari
>
>
Re: Review Request 25160: Major throughput improvement with mixed
workloads
Posted by Kfir Lev-Ari <kf...@gmail.com>.
> On Sept. 2, 2014, 8:23 p.m., Grant Monroe wrote:
> > ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java, line 391
> > <https://reviews.apache.org/r/25160/diff/1/?file=671464#file671464line391>
> >
> > what if request is null?
Right, it'll be an error since we reach this code only based on the check that committed head isn't null, I'll add an error print + return.
- Kfir
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25160/#review52074
-----------------------------------------------------------
On Aug. 28, 2014, 6:27 p.m., Kfir Lev-Ari wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25160/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2014, 6:27 p.m.)
>
>
> Review request for zookeeper, Raul Gutierrez Segales and Alexander Shraer.
>
>
> Repository: zookeeper
>
>
> Description
> -------
>
> Please see https://issues.apache.org/jira/browse/ZOOKEEPER-2024
>
>
> Diffs
> -----
>
> ./src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1619360
> ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java 1619360
> ./src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorTest.java 1619360
>
> Diff: https://reviews.apache.org/r/25160/diff/
>
>
> Testing
> -------
>
> The attached unit tests, as well as the system test found in https://issues.apache.org/jira/browse/ZOOKEEPER-2023.
>
>
> Thanks,
>
> Kfir Lev-Ari
>
>