You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/08/18 05:07:00 UTC
[jira] [Commented] (GEODE-8435) restore gfsh ability to connect if
serialization versions match regardless of product version
[ https://issues.apache.org/jira/browse/GEODE-8435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17179359#comment-17179359 ]
ASF GitHub Bot commented on GEODE-8435:
---------------------------------------
onichols-pivotal opened a new pull request #5462:
URL: https://github.com/apache/geode/pull/5462
This used to work but was broken recently by changes to rely exclusively on product version.
Although Geode releases were never impacted, loss of this feature causes quite a headache for developers that don't typically pass a product version in their gradle build command, leading to unintuitive errors like `Cannot use a 0.0.0 gfsh client to connect to a 0.0.0 cluster`
Serialization version is the surest way to check gfsh compatibility, since in general it is unwise to make assumptions about product version because it is not intrinsic to Geode.
This PR restores the serialization version check, which was lost during GEODE-8331. However, serialization version was only exposed in Geode 1.12, and since we are now interoperable back to Geode 1.10, the product version range check is retained as a fallback.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> restore gfsh ability to connect if serialization versions match regardless of product version
> ---------------------------------------------------------------------------------------------
>
> Key: GEODE-8435
> URL: https://issues.apache.org/jira/browse/GEODE-8435
> Project: Geode
> Issue Type: Bug
> Components: gfsh
> Reporter: Owen Nichols
> Priority: Major
>
> This used to work but was broken recently by changes for GEODE-8331. Although this does not impact Geode releases, it causes quite a headache for developers that don't typically pass a product version in their gradle build command.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)