[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #6837: TP expired DS certs: adds color coding to expired and soon-expired certs

[GitBox <gi...@apache.org>]

ocket8888 commented on code in PR #6837:
URL: https://github.com/apache/trafficcontrol/pull/6837#discussion_r879829174


##########
traffic_portal/app/src/common/modules/table/certExpirations/TableCertExpirationsController.js:
##########
@@ -84,6 +84,17 @@ var TableCertExpirationsController = function(tableName, certExpirations, $scope
 				// Event is outside the digest cycle, so we need to trigger one.
 				$scope.$apply();
 			}
+		},
+		rowClassRules: {
+			'expired-cert': function(params) {
+				let now = new Date();
+				return params.data.expiration < now;
+			},
+			'soon-expired-cert': function(params) {
+				let thirtyDays = new Date();

Review Comment:
   nit: `now` and `thirtyDays` are never reassigned, could be `const`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org