You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2015/09/21 23:25:41 UTC

[Bug 58441] New: [PATCH] Define equals method for CellRangeAddressBase

https://bz.apache.org/bugzilla/show_bug.cgi?id=58441

            Bug ID: 58441
           Summary: [PATCH] Define equals method for CellRangeAddressBase
           Product: POI
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: SS Common
          Assignee: dev@poi.apache.org
          Reporter: javenoneal@gmail.com
            Blocks: 58348

Created attachment 33124
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33124&action=edit
CellRangeAddressBase with added equals and hashCode methods

CellRangeAddressBase doesn't have an equals method.

Equals method should determine if two CellRangeAddressBases refer to the same
area by comparing _firstRow, _lastRow, _firstCol, _lastCol. Since it's possible
for (_firstRow and _lastRow) and (_firstCol and _lastCol) to become inverted, a
comparison should sort the fields.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 58441] [PATCH] Define equals method for CellRangeAddressBase

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58441

Javen ONeal <ja...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Javen ONeal <ja...@gmail.com> ---
Implemented in r1710172

Deployed to trunk.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org

[Bug 58441] [PATCH] Define equals method for CellRangeAddressBase

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58441

Javen ONeal <ja...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #33124|0                           |1
        is obsolete|                            |

--- Comment #1 from Javen ONeal <ja...@gmail.com> ---
Created attachment 33125
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33125&action=edit
CellRangeAddressBase with added equals and hashCode methods, including unit
tests

Add unit tests for new methods.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org