[jira] Commented: (ADFFACES-125) XMLMenuModel needs public getStream() method so that XMLMenuModel can be extended.

["Adam Winer (JIRA)" <ad...@incubator.apache.org>]

    [ http://issues.apache.org/jira/browse/ADFFACES-125?page=comments#action_12429623 ] 
            
Adam Winer commented on ADFFACES-125:
-------------------------------------

The patch no longer can be applied to the current state of the trunk.

Can you re-create it?

Also, I don't agree with changing from three methods returning Maps to one method returning
a List of Maps;  hardcoded positions and type information isn't an improved API, and this
change means a loss of type-safety (esp. with Java 5 generics).  Please undo this change.

> XMLMenuModel needs public getStream() method so that XMLMenuModel can be extended.
> ----------------------------------------------------------------------------------
>
>                 Key: ADFFACES-125
>                 URL: http://issues.apache.org/jira/browse/ADFFACES-125
>             Project: MyFaces ADF-Faces
>          Issue Type: Improvement
>            Reporter: Gary Kind
>         Attachments: trunk.patch
>
>
> Currently, getStream() is a private method in MenuContentHandlerImpl.java that provides an InputStream to the menu metadata used by the parser to construct the menu model (tree model).  Extenders of XMLMenuModel may want to override the default InputStream (derived from the file system).  I have added a public getStream() method to XMLMenuModel.java, removed the private getStream() method from MenuContentHandlerImpl.java, and MenuContentHandlerImpl.getTreeModel() calls back to its local menu model's getStream() method.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira