You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "chenhao-db (via GitHub)" <gi...@apache.org> on 2025/07/16 23:49:28 UTC
[PR] [SPARK-52833] Fix VariantBuilder.appendFloat [spark]
chenhao-db opened a new pull request, #51526:
URL: https://github.com/apache/spark/pull/51526
### What changes were proposed in this pull request?
There is a small bug that `appendFloat` appends 8 bytes, which should be 4 instead. This doesn't cause a correctness issue, because `writeLong` writes the least significant `numBytes` bytes. When int is extended to long, the lower 4 bytes don't change. This may cause an exception when the buffer doesn't have enough capacity.
### Why are the changes needed?
Bug fix.
### Does this PR introduce _any_ user-facing change?
Yes, as stated above.
### How was this patch tested?
Unit test. It would fail (throw an exception) without the fix.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52833][SQL] Fix `VariantBuilder.appendFloat` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #51526: [SPARK-52833][SQL] Fix `VariantBuilder.appendFloat`
URL: https://github.com/apache/spark/pull/51526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52833] Fix VariantBuilder.appendFloat [spark]
Posted by "chenhao-db (via GitHub)" <gi...@apache.org>.
chenhao-db commented on PR #51526:
URL: https://github.com/apache/spark/pull/51526#issuecomment-3081827069
@cloud-fan Could you help review? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52833][SQL] Fix `VariantBuilder.appendFloat` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #51526:
URL: https://github.com/apache/spark/pull/51526#issuecomment-3085656749
Merged to master/4.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org