You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Rui Wang (Jira)" <ji...@apache.org> on 2020/08/04 18:27:00 UTC

[jira] [Commented] (BEAM-10595) Remove rules that not work well with Java UDF

    [ https://issues.apache.org/jira/browse/BEAM-10595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17171032#comment-17171032 ] 

Rui Wang commented on BEAM-10595:
---------------------------------

The implementation in PR#12398, especially this class: https://github.com/apache/beam/pull/12398/files#diff-71d77071a0216304d3c02b31d5880b48R29

might clarify better on the intention of this JIRA.

> Remove rules that not work well with Java UDF
> ---------------------------------------------
>
>                 Key: BEAM-10595
>                 URL: https://issues.apache.org/jira/browse/BEAM-10595
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql-zetasql
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: P2
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> In order to support Java UDF, we need both BeamZetaSqlCalcRel and BeamCalcRel. It is 
> because BeamZetaSqlCalcRel can execute ZetaSQL built-in functions while BeamCalcRel
> can execute UDFs. So during planning, we expect both Filter and Project are converted to
>  a Calc before merging with other Projec/Filter/Calc. Thus we should not add FilterCalcMergeRuleand ProjectCalcMergeRule.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)