You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/02/29 21:07:58 UTC
[GitHub] [fineract] percyashu opened a new pull request #715: FINERACT-823
Gradle modernizer plugin
percyashu opened a new pull request #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715
## Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket https://issues.apache.org/jira/browse/FINERACT-823
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #715: FINERACT-823 Gradle
modernizer plugin
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715#issuecomment-592999506
Thanks for this PR @percyashu ...Next time..before sending a PR, Make sure to run the integration tests locally first using ./gradlew clean integrationTest.. When all passes then can you send a PR... I see this PR has a failure somewhere..Will you like to investigate and find out why? Then update the PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] percyashu closed pull request #715: FINERACT-823 Gradle
modernizer plugin
Posted by GitBox <gi...@apache.org>.
percyashu closed pull request #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] percyashu commented on issue #715: FINERACT-823 Gradle
modernizer plugin
Posted by GitBox <gi...@apache.org>.
percyashu commented on issue #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715#issuecomment-594374166
@awasum OK I will do that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #715: FINERACT-823 Gradle
modernizer plugin
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715#issuecomment-594355862
@percyashu , Please squash these 3 commits into 1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] percyashu opened a new pull request #715: FINERACT-823
Gradle modernizer plugin
Posted by GitBox <gi...@apache.org>.
percyashu opened a new pull request #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715
## Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket https://issues.apache.org/jira/browse/FINERACT-823
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] percyashu commented on issue #715: FINERACT-823 Gradle
modernizer plugin
Posted by GitBox <gi...@apache.org>.
percyashu commented on issue #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715#issuecomment-594320621
@awasum or @vorburger could you review this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger merged pull request #715: FINERACT-823 Gradle
modernizer plugin
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] percyashu commented on issue #715: FINERACT-823 Gradle
modernizer plugin
Posted by GitBox <gi...@apache.org>.
percyashu commented on issue #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715#issuecomment-593372856
@awasum I did run ./gradlew clean integrationTest and FixedDepositTest does not fail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] percyashu commented on issue #715: FINERACT-823 Gradle
modernizer plugin
Posted by GitBox <gi...@apache.org>.
percyashu commented on issue #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715#issuecomment-594629243
@awasum I have squash them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on a change in pull request #715:
FINERACT-823 Gradle modernizer plugin
Posted by GitBox <gi...@apache.org>.
awasum commented on a change in pull request #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715#discussion_r390906285
##########
File path: fineract-provider/build.gradle
##########
@@ -298,6 +300,22 @@ if (project.hasProperty('security') && project.getProperty('security') == 'oauth
}
}
+modernizer {
+ includeTestClasses = false
+ failOnViolations = false
+
+ violationLogLevel="warn"
Review comment:
Ping @percyashu , will u like o address this so it can be merged by @vorburger ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] vorburger commented on a change in pull request #715:
FINERACT-823 Gradle modernizer plugin
Posted by GitBox <gi...@apache.org>.
vorburger commented on a change in pull request #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715#discussion_r389364312
##########
File path: fineract-provider/build.gradle
##########
@@ -298,6 +300,22 @@ if (project.hasProperty('security') && project.getProperty('security') == 'oauth
}
}
+modernizer {
+ includeTestClasses = false
+ failOnViolations = false
+
+ violationLogLevel="warn"
Review comment:
Thanks for this contribution, I love it! Seeing that this only adds additional warn logs during the build, I fear everyone will just ignore this, and it won't really add any value... (This is why Checkstyle and SpotBugs are "enforced" now; if we don't do that, it's pretty much pointless.) I think what would be much more useful is if this was set to fail on violation, at violation log level error. I suspect that probably will cause some failure, but we should fix those...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] percyashu opened a new pull request #715: FINERACT-823
Gradle modernizer plugin
Posted by GitBox <gi...@apache.org>.
percyashu opened a new pull request #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715
## Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket https://issues.apache.org/jira/browse/FINERACT-823
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] percyashu closed pull request #715: FINERACT-823 Gradle
modernizer plugin
Posted by GitBox <gi...@apache.org>.
percyashu closed pull request #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] percyashu commented on issue #715: FINERACT-823 Gradle
modernizer plugin
Posted by GitBox <gi...@apache.org>.
percyashu commented on issue #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715#issuecomment-599824034
@vorburger I resolved all violation except does pertaining to replacing Joda.time with Java.time which will be handle in a PR to issue https://issues.apache.org/jira/projects/FINERACT/issues/FINERACT-826.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] percyashu commented on a change in pull request #715:
FINERACT-823 Gradle modernizer plugin
Posted by GitBox <gi...@apache.org>.
percyashu commented on a change in pull request #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715#discussion_r391486396
##########
File path: fineract-provider/build.gradle
##########
@@ -298,6 +300,22 @@ if (project.hasProperty('security') && project.getProperty('security') == 'oauth
}
}
+modernizer {
+ includeTestClasses = false
+ failOnViolations = false
+
+ violationLogLevel="warn"
Review comment:
I will make the changes and fix the violation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fineract] awasum commented on issue #715: FINERACT-823 Gradle
modernizer plugin
Posted by GitBox <gi...@apache.org>.
awasum commented on issue #715: FINERACT-823 Gradle modernizer plugin
URL: https://github.com/apache/fineract/pull/715#issuecomment-593254985
@percyashu Please..make sure you complete 1 issue before moving to the next one. THere is no point opening more than 1 PR at a time and try to work on all at same time. In general, thats usually a bad idea especially for new programmers. Finish one, then pick another and you find that you make more progress that way. Leave the other PRs you have opened like that and take one of them to fix before moving to the next.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services