You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/11/22 03:53:14 UTC

[GitHub] [spark] uncleGen edited a comment on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui

uncleGen edited a comment on issue #26201: [SPARK-29543][SS][UI] Init structured streaming ui
URL: https://github.com/apache/spark/pull/26201#issuecomment-557377114
 
 
   Thanks for your code review. @dongjoon-hyun @xuanyuanking @sarutak @HeartSaVioR 
   Here is a summarize of code change after `e30af98`:
   - remove `Last Progress` column in `StreamingQueryPage`.
   - `maxProcessRate` can be NaN. This problem will be fixed in #26610.
   - add a new UI tab, i.e "Structure Streaming", to show the list of streaming query.
   - the legend area can overlap with the graph area. fixed.
   - itemize the properties of streaming query in its statistics page.
   - add a new "structured-streaming-page.js" to separate logic for Structured Streamning
   - code clean to reduce deduplicate and redundant work
   - remove redundant lock
   - refactor the `activeStreamingQueries` in `sharedState` to keep inactive streaming query.
   - use `<no name>` for those query without name instead of `null`
   - fix some code style
   
   ![image](https://user-images.githubusercontent.com/7402327/69396673-06a6dc00-0d1e-11ea-94a8-546d252e4fce.png)
   ![image](https://user-images.githubusercontent.com/7402327/69396684-10304400-0d1e-11ea-8594-0722e81f39be.png)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org