You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by jiangxb1987 <gi...@git.apache.org> on 2018/02/01 01:03:57 UTC

[GitHub] spark pull request #20361: [SPARK-23188][SQL] Make vectorized columar reader...

Github user jiangxb1987 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20361#discussion_r165234841
  
    --- Diff: sql/core/src/main/java/org/apache/spark/sql/execution/datasources/orc/OrcColumnarBatchReader.java ---
    @@ -49,8 +49,9 @@
      * After creating, `initialize` and `initBatch` should be called sequentially.
      */
     public class OrcColumnarBatchReader extends RecordReader<Void, ColumnarBatch> {
    -  // TODO: make this configurable.
    -  private static final int CAPACITY = 4 * 1024;
    +
    +  // The default size of vectorized batch.
    --- End diff --
    
    How about rephrase to `The capacity of vectorized batch` ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org