You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "David Smiley (Jira)" <ji...@apache.org> on 2024/11/10 16:51:00 UTC

[jira] [Resolved] (SOLR-2292) Lock down NamedList API, remove inefficent and esoteric methods

     [ https://issues.apache.org/jira/browse/SOLR-2292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Smiley resolved SOLR-2292.
--------------------------------
    Resolution: Won't Fix

Marking as won't-fix.  It's not quite clear what the proposal really is, other than reviewing/auditing.

> Lock down NamedList API, remove inefficent and esoteric methods
> ---------------------------------------------------------------
>
>                 Key: SOLR-2292
>                 URL: https://issues.apache.org/jira/browse/SOLR-2292
>             Project: Solr
>          Issue Type: Task
>            Reporter: Chris M. Hostetter
>            Priority: Major
>             Fix For: 6.0, 4.9
>
>
> Over in SOLR-2288, rmuir made some good points about locking down the NamedList API to protect people...
> {quote}
> I looked at your patch, and personally I think NamedList should really be type-safe.
> If users want to use it in a type-unsafe way, thats fine, but *the container itself shouldn't be List<Object>*.
> {quote}
> ...
> {quote}
> Separately, i just want to say the following about NamedList:
> All uses of this API should really be reviewed. I'm quite aware that it warns you about the fact that its slow for certain operations,
> but in my opinion these *slow operations such as get(String, int) should be deprecated and removed*.
> Any users that are using NamedList in this way, especially in loops, are very likely using the wrong datastructure.
> {quote}
> (emphasis added by me)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org