[GitHub] [openwhisk] bdoyle0182 commented on a diff in pull request #5388: fix memory queue stuck in removed state edge case

["bdoyle0182 (via GitHub)" <gi...@apache.org>]

bdoyle0182 commented on code in PR #5388:
URL: https://github.com/apache/openwhisk/pull/5388#discussion_r1148421740


##########
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/MemoryQueue.scala:
##########
@@ -456,6 +456,9 @@ class MemoryQueue(private val etcdClient: EtcdClient,
 
     // This is not supposed to happen. This will ensure the queue does not run forever.

Review Comment:
   @style95 I don't think this is actually true since there is no `context.parent ! queueRemovedMsg` when the `Idle` state times out which is fairly frequent behavior and thus `QueueRemoved` is never sent to the manager until `Removed` state times out which wasn't guaranteed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org