[jira] [Commented] (AMBARI-15588) Use ">>" instead of ">" to write ambari-metrics-monitor.out

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-15588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214127#comment-15214127 ] 

Hadoop QA commented on AMBARI-15588:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12795575/AMBARI-15588.01.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/6054//testReport/
Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/6054//console

This message is automatically generated.

> Use ">>" instead of ">" to write ambari-metrics-monitor.out
> -----------------------------------------------------------
>
>                 Key: AMBARI-15588
>                 URL: https://issues.apache.org/jira/browse/AMBARI-15588
>             Project: Ambari
>          Issue Type: Improvement
>          Components: ambari-metrics
>            Reporter: Akira AJISAKA
>            Assignee: Akira AJISAKA
>              Labels: newbie
>         Attachments: AMBARI-15588.01.patch
>
>
> If we want to rotate ambari-metrics-monitor.out by logrotate (using copytruncate option), we need to use ">>" instead of ">" not to keep the file offset to write. If the offset is kept, null characters are padded in the new file.
> {code:title=ambari-metrics-monitor}
>     nohup ${PYTHON} ${METRIC_MONITOR_PY_SCRIPT} "$@" > ${OUTFILE} 2>&1 &
> {code}
> should be 
> {code}
>     nohup ${PYTHON} ${METRIC_MONITOR_PY_SCRIPT} "$@" >> ${OUTFILE} 2>&1 &
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)