You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "bdemers (via GitHub)" <gi...@apache.org> on 2025/09/12 16:00:27 UTC
[PR] Add ScimRequestContext to Request.create method [directory-scimple]
bdemers opened a new pull request, #909:
URL: https://github.com/apache/directory-scimple/pull/909
Deprecate old method, new method falls back to previous
Wart, implementors must still implement the old method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Add ScimRequestContext to Request.create method [directory-scimple]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #909:
URL: https://github.com/apache/directory-scimple/pull/909#issuecomment-3285857585
View details about the 'Maven Verify (with Java 17-zulu)' build [1668](https://github.com/apache/directory-scimple/actions/runs/17679639483/job/50250498029) in the [Build Scan](https://develocity.apache.org/s/ih5sby7xyptmk) 📊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Add ScimRequestContext to Request.create method [directory-scimple]
Posted by "CS-Birb (via GitHub)" <gi...@apache.org>.
CS-Birb commented on PR #909:
URL: https://github.com/apache/directory-scimple/pull/909#issuecomment-3290076754
I'd struggled to think of an ideal fallback strategy with my previous PR too. Bit of a catch-22.
Making the new method `default` has the lowest impact for existing implementations of the Repository, but to use the new method will require keeping an override for the old.
Between M1 and the next production release there are already breaking changes in the Repository method signatures (I.e. version string to ETags, attribute references in more methods) so this may be a viable time to implement this as a breaking change.
Adding new fields later on to the ScimRequestContext could then only be minor changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Add ScimRequestContext to Request.create method [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers closed pull request #909: Add ScimRequestContext to Request.create method
URL: https://github.com/apache/directory-scimple/pull/909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Add ScimRequestContext to Request.create method [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on PR #909:
URL: https://github.com/apache/directory-scimple/pull/909#issuecomment-3285858859
@CS-Birb I took a quick pass at replacing the attribute args with a `ScimRequestContext`
(just the `create` method at first to get a feel for how it would look, but the rest of the methods would need to be implemented before merging)
I think this could work, but I don't like my fall back strategy (default method, calls the old method). Implementors would need to implement the new method, and the old, which feel wrong.
Any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Add ScimRequestContext to Request.create method [directory-scimple]
Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on PR #909:
URL: https://github.com/apache/directory-scimple/pull/909#issuecomment-3921922873
Replaced with #1025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Add ScimRequestContext to Request.create method [directory-scimple]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #909:
URL: https://github.com/apache/directory-scimple/pull/909#issuecomment-3285848333
View details about the 'Apache Rat - Check' build [533](https://github.com/apache/directory-scimple/actions/runs/17679639449/job/50250498176) in the [Build Scan](https://develocity.apache.org/s/epfosp4wsbvu4) 📊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org
Re: [PR] Add ScimRequestContext to Request.create method [directory-scimple]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #909:
URL: https://github.com/apache/directory-scimple/pull/909#issuecomment-3285857278
View details about the 'Maven Verify (with Java 21-zulu)' build [1668](https://github.com/apache/directory-scimple/actions/runs/17679639483/job/50250498050) in the [Build Scan](https://develocity.apache.org/s/426lvauym6d5u) 📊
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org