You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2010/02/02 18:27:03 UTC
svn commit: r905717 -
/tomcat/trunk/java/org/apache/catalina/core/StandardService.java
Author: markt
Date: Tue Feb 2 17:27:00 2010
New Revision: 905717
URL: http://svn.apache.org/viewvc?rev=905717&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48039
Return immediately if already started
Modified:
tomcat/trunk/java/org/apache/catalina/core/StandardService.java
Modified: tomcat/trunk/java/org/apache/catalina/core/StandardService.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/StandardService.java?rev=905717&r1=905716&r2=905717&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/catalina/core/StandardService.java (original)
+++ tomcat/trunk/java/org/apache/catalina/core/StandardService.java Tue Feb 2 17:27:00 2010
@@ -497,6 +497,7 @@
// Validate and update our current component state
if (log.isInfoEnabled() && started) {
log.info(sm.getString("standardService.start.started"));
+ return;
}
if( ! initialized )
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r905717 - /tomcat/trunk/java/org/apache/catalina/core/StandardService.java
Posted by Mark Thomas <ma...@apache.org>.
On 02/02/2010 17:34, Konstantin Kolinko wrote:
> 2010/2/2 <ma...@apache.org>:
>> Author: markt
>> Date: Tue Feb 2 17:27:00 2010
>> New Revision: 905717
>>
>> URL: http://svn.apache.org/viewvc?rev=905717&view=rev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48039
>> Return immediately if already started
>>
>> Modified:
>> tomcat/trunk/java/org/apache/catalina/core/StandardService.java
>>
>
>> // Validate and update our current component state
>> if (log.isInfoEnabled() && started) {
>> log.info(sm.getString("standardService.start.started"));
>> + return;
>> }
>>
>
> It should be
>
> if (started) {
> if(log.isInfoEnabled()) {
> log.info(sm.getString("standardService.start.started"));
> }
> return;
> }
Doh. Thanks for the catch.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r905717 - /tomcat/trunk/java/org/apache/catalina/core/StandardService.java
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/2/2 <ma...@apache.org>:
> Author: markt
> Date: Tue Feb 2 17:27:00 2010
> New Revision: 905717
>
> URL: http://svn.apache.org/viewvc?rev=905717&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48039
> Return immediately if already started
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/core/StandardService.java
>
> // Validate and update our current component state
> if (log.isInfoEnabled() && started) {
> log.info(sm.getString("standardService.start.started"));
> + return;
> }
>
It should be
if (started) {
if(log.isInfoEnabled()) {
log.info(sm.getString("standardService.start.started"));
}
return;
}
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org