You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Meghna Kale <me...@sungard.com> on 2012/11/08 12:58:53 UTC
Review Request: Test cases for com.cloud.api.commands using Mockito.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7966/
-----------------------------------------------------------
Review request for cloudstack, Chip Childers, Chiradeep Vittal, and Alex Huang.
Description
-------
Test cases for com.cloud.api.commands using Mockito.
Diffs
-----
api/pom.xml f25a6bc
api/src/com/cloud/api/commands/ActivateProjectCmd.java 20b5507
api/src/com/cloud/api/commands/AddAccountToProjectCmd.java 5178aa3
api/test/com/cloud/api/commands/ActivateProjectCmdTest.java PRE-CREATION
api/test/com/cloud/api/commands/AddAccountToProjectCmdTest.java PRE-CREATION
api/test/com/cloud/api/commands/AddClusterCmdTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/7966/diff/
Testing
-------
Tested with the maven test cases.
Thanks,
Meghna Kale
Re: Review Request: Test cases for com.cloud.api.commands using Mockito.
Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7966/#review13245
-----------------------------------------------------------
api/pom.xml
<https://reviews.apache.org/r/7966/#comment28472>
Best to inherit the mockito version from the root pom.xml.
- Prasanna Santhanam
On Nov. 8, 2012, 11:58 a.m., Meghna Kale wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7966/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2012, 11:58 a.m.)
>
>
> Review request for cloudstack, Chip Childers, Chiradeep Vittal, and Alex Huang.
>
>
> Description
> -------
>
> Test cases for com.cloud.api.commands using Mockito.
>
>
> Diffs
> -----
>
> api/pom.xml f25a6bc
> api/src/com/cloud/api/commands/ActivateProjectCmd.java 20b5507
> api/src/com/cloud/api/commands/AddAccountToProjectCmd.java 5178aa3
> api/test/com/cloud/api/commands/ActivateProjectCmdTest.java PRE-CREATION
> api/test/com/cloud/api/commands/AddAccountToProjectCmdTest.java PRE-CREATION
> api/test/com/cloud/api/commands/AddClusterCmdTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/7966/diff/
>
>
> Testing
> -------
>
> Tested with the maven test cases.
>
>
> Thanks,
>
> Meghna Kale
>
>
Re: Review Request: Test cases for com.cloud.api.commands using Mockito.
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7966/#review13632
-----------------------------------------------------------
Ship it!
This has been committed to master. Please mark this review as "closed / submitted".
- Chip Childers
On Nov. 19, 2012, 12:36 p.m., Meghna Kale wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7966/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 12:36 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Prasanna Santhanam, Chiradeep Vittal, and Alex Huang.
>
>
> Description
> -------
>
> Test cases for com.cloud.api.commands using Mockito.
>
>
> Diffs
> -----
>
> api/pom.xml f25a6bc
> api/src/com/cloud/api/commands/ActivateProjectCmd.java 20b5507
> api/src/com/cloud/api/commands/AddAccountToProjectCmd.java 5178aa3
> api/test/com/cloud/api/commands/ActivateProjectCmdTest.java PRE-CREATION
> api/test/com/cloud/api/commands/AddAccountToProjectCmdTest.java PRE-CREATION
> api/test/com/cloud/api/commands/AddClusterCmdTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/7966/diff/
>
>
> Testing
> -------
>
> Tested with the maven test cases.
>
>
> Thanks,
>
> Meghna Kale
>
>
Re: Review Request: Test cases for com.cloud.api.commands using Mockito.
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7966/#review13589
-----------------------------------------------------------
The patch merges into master cleanly, and the tests pass. I'm going to give this a once over again tomorrow, and then commit it (unless there are outstanding objections).
- Chip Childers
On Nov. 19, 2012, 12:36 p.m., Meghna Kale wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7966/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 12:36 p.m.)
>
>
> Review request for cloudstack, Chip Childers, Prasanna Santhanam, Chiradeep Vittal, and Alex Huang.
>
>
> Description
> -------
>
> Test cases for com.cloud.api.commands using Mockito.
>
>
> Diffs
> -----
>
> api/pom.xml f25a6bc
> api/src/com/cloud/api/commands/ActivateProjectCmd.java 20b5507
> api/src/com/cloud/api/commands/AddAccountToProjectCmd.java 5178aa3
> api/test/com/cloud/api/commands/ActivateProjectCmdTest.java PRE-CREATION
> api/test/com/cloud/api/commands/AddAccountToProjectCmdTest.java PRE-CREATION
> api/test/com/cloud/api/commands/AddClusterCmdTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/7966/diff/
>
>
> Testing
> -------
>
> Tested with the maven test cases.
>
>
> Thanks,
>
> Meghna Kale
>
>
Re: Review Request: Test cases for com.cloud.api.commands using Mockito.
Posted by Meghna Kale <me...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7966/
-----------------------------------------------------------
(Updated Nov. 19, 2012, 12:36 p.m.)
Review request for cloudstack, Chip Childers, Prasanna Santhanam, Chiradeep Vittal, and Alex Huang.
Changes
-------
added more test cases.
Description
-------
Test cases for com.cloud.api.commands using Mockito.
Diffs
-----
api/pom.xml f25a6bc
api/src/com/cloud/api/commands/ActivateProjectCmd.java 20b5507
api/src/com/cloud/api/commands/AddAccountToProjectCmd.java 5178aa3
api/test/com/cloud/api/commands/ActivateProjectCmdTest.java PRE-CREATION
api/test/com/cloud/api/commands/AddAccountToProjectCmdTest.java PRE-CREATION
api/test/com/cloud/api/commands/AddClusterCmdTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/7966/diff/
Testing
-------
Tested with the maven test cases.
Thanks,
Meghna Kale
Re: Review Request: Test cases for com.cloud.api.commands using Mockito.
Posted by Meghna Kale <me...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7966/
-----------------------------------------------------------
(Updated Nov. 19, 2012, 12:35 p.m.)
Review request for cloudstack, Chip Childers, Prasanna Santhanam, Chiradeep Vittal, and Alex Huang.
Changes
-------
added more test cases.
Description
-------
Test cases for com.cloud.api.commands using Mockito.
Diffs
-----
api/pom.xml f25a6bc
api/src/com/cloud/api/commands/ActivateProjectCmd.java 20b5507
api/src/com/cloud/api/commands/AddAccountToProjectCmd.java 5178aa3
api/test/com/cloud/api/commands/ActivateProjectCmdTest.java PRE-CREATION
api/test/com/cloud/api/commands/AddAccountToProjectCmdTest.java PRE-CREATION
api/test/com/cloud/api/commands/AddClusterCmdTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/7966/diff/
Testing
-------
Tested with the maven test cases.
Thanks,
Meghna Kale
Re: Review Request: Test cases for com.cloud.api.commands using Mockito.
Posted by Meghna Kale <me...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7966/
-----------------------------------------------------------
(Updated Nov. 9, 2012, 12:05 p.m.)
Review request for cloudstack, Chip Childers, Prasanna Santhanam, Chiradeep Vittal, and Alex Huang.
Changes
-------
Review changes incorporated
Description
-------
Test cases for com.cloud.api.commands using Mockito.
Diffs
-----
api/pom.xml f25a6bc
api/src/com/cloud/api/commands/ActivateProjectCmd.java 20b5507
api/src/com/cloud/api/commands/AddAccountToProjectCmd.java 5178aa3
api/test/com/cloud/api/commands/ActivateProjectCmdTest.java PRE-CREATION
api/test/com/cloud/api/commands/AddAccountToProjectCmdTest.java PRE-CREATION
api/test/com/cloud/api/commands/AddClusterCmdTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/7966/diff/
Testing
-------
Tested with the maven test cases.
Thanks,
Meghna Kale
Re: Review Request: Test cases for com.cloud.api.commands using Mockito.
Posted by Meghna Kale <me...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7966/
-----------------------------------------------------------
(Updated Nov. 9, 2012, 10:13 a.m.)
Review request for cloudstack, Chip Childers, Prasanna Santhanam, Chiradeep Vittal, and Alex Huang.
Description
-------
Test cases for com.cloud.api.commands using Mockito.
Diffs
-----
api/pom.xml f25a6bc
api/src/com/cloud/api/commands/ActivateProjectCmd.java 20b5507
api/src/com/cloud/api/commands/AddAccountToProjectCmd.java 5178aa3
api/test/com/cloud/api/commands/ActivateProjectCmdTest.java PRE-CREATION
api/test/com/cloud/api/commands/AddAccountToProjectCmdTest.java PRE-CREATION
api/test/com/cloud/api/commands/AddClusterCmdTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/7966/diff/
Testing
-------
Tested with the maven test cases.
Thanks,
Meghna Kale
Re: Review Request: Test cases for com.cloud.api.commands using Mockito.
Posted by Meghna Kale <me...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7966/
-----------------------------------------------------------
(Updated Nov. 9, 2012, 6:27 a.m.)
Review request for cloudstack, Chip Childers, Chiradeep Vittal, and Alex Huang.
Changes
-------
Review comments incorporated in the test cases for com.cloud.api.commands
Description
-------
Test cases for com.cloud.api.commands using Mockito.
Diffs
-----
api/pom.xml f25a6bc
api/src/com/cloud/api/commands/ActivateProjectCmd.java 20b5507
api/src/com/cloud/api/commands/AddAccountToProjectCmd.java 5178aa3
api/test/com/cloud/api/commands/ActivateProjectCmdTest.java PRE-CREATION
api/test/com/cloud/api/commands/AddAccountToProjectCmdTest.java PRE-CREATION
api/test/com/cloud/api/commands/AddClusterCmdTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/7966/diff/
Testing
-------
Tested with the maven test cases.
Thanks,
Meghna Kale
Re: Review Request: Test cases for com.cloud.api.commands using Mockito.
Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7966/#review13244
-----------------------------------------------------------
api/test/com/cloud/api/commands/ActivateProjectCmdTest.java
<https://reviews.apache.org/r/7966/#comment28469>
Please add the Apache License Header to new files
api/test/com/cloud/api/commands/ActivateProjectCmdTest.java
<https://reviews.apache.org/r/7966/#comment28470>
@author tags should be removed. Reset your IDE to avoid this.
api/test/com/cloud/api/commands/AddAccountToProjectCmdTest.java
<https://reviews.apache.org/r/7966/#comment28471>
License header reqd
- Prasanna Santhanam
On Nov. 8, 2012, 11:58 a.m., Meghna Kale wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7966/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2012, 11:58 a.m.)
>
>
> Review request for cloudstack, Chip Childers, Chiradeep Vittal, and Alex Huang.
>
>
> Description
> -------
>
> Test cases for com.cloud.api.commands using Mockito.
>
>
> Diffs
> -----
>
> api/pom.xml f25a6bc
> api/src/com/cloud/api/commands/ActivateProjectCmd.java 20b5507
> api/src/com/cloud/api/commands/AddAccountToProjectCmd.java 5178aa3
> api/test/com/cloud/api/commands/ActivateProjectCmdTest.java PRE-CREATION
> api/test/com/cloud/api/commands/AddAccountToProjectCmdTest.java PRE-CREATION
> api/test/com/cloud/api/commands/AddClusterCmdTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/7966/diff/
>
>
> Testing
> -------
>
> Tested with the maven test cases.
>
>
> Thanks,
>
> Meghna Kale
>
>