You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2015/09/23 17:05:45 UTC

Review Request 38679: API returns incorrect info about alerts

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38679/
-----------------------------------------------------------

Review request for Ambari and Myroslav Papirkovskyy.


Bugs: AMBARI-13209
    https://issues.apache.org/jira/browse/AMBARI-13209


Repository: ambari


Description
-------

Steps:
# Deploy cluster.
# Stop some service.
# Wait for alerts appearing.

Result: Hosts page button does not have counter with alerted hosts.
"http://host:8080/api/v1/clusters/cl1?fields=Clusters/health_report,Clusters/total_hosts,alerts_summary_hosts&minimal_response=true":
{code}
{
  "Clusters" : {
    "cluster_name" : "cl1",
    "health_report" : {
      "Host/stale_config" : 0,
      "Host/maintenance_state" : 0,
      "Host/host_state/HEALTHY" : 4,
      "Host/host_state/UNHEALTHY" : 0,
      "Host/host_state/HEARTBEAT_LOST" : 0,
      "Host/host_state/INIT" : 0,
      "Host/host_status/HEALTHY" : 0,
      "Host/host_status/UNHEALTHY" : 1,
      "Host/host_status/UNKNOWN" : 0,
      "Host/host_status/ALERT" : 3
    },
    "total_hosts" : 4,
    "version" : "HDP-2.3"
  },
  "alerts_summary_hosts" : {
    "CRITICAL" : 0,
    "OK" : 4,
    "UNKNOWN" : 0,
    "WARNING" : 0
  }
}
{code}
{code}
"CRITICAL" : 0,
"WARNING" : 0
{code}


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java 39b12c4 

Diff: https://reviews.apache.org/r/38679/diff/


Testing
-------

mvn clean test


Thanks,

Dmitro Lisnichenko


Re: Review Request 38679: API returns incorrect info about alerts

Posted by Myroslav Papirkovskyy <mp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38679/#review100198
-----------------------------------------------------------

Ship it!


Ship It!

- Myroslav Papirkovskyy


On Вер. 23, 2015, 6:05 після полудня, Dmitro Lisnichenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38679/
> -----------------------------------------------------------
> 
> (Updated Вер. 23, 2015, 6:05 після полудня)
> 
> 
> Review request for Ambari and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-13209
>     https://issues.apache.org/jira/browse/AMBARI-13209
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Steps:
> # Deploy cluster.
> # Stop some service.
> # Wait for alerts appearing.
> 
> Result: Hosts page button does not have counter with alerted hosts.
> "http://host:8080/api/v1/clusters/cl1?fields=Clusters/health_report,Clusters/total_hosts,alerts_summary_hosts&minimal_response=true":
> {code}
> {
>   "Clusters" : {
>     "cluster_name" : "cl1",
>     "health_report" : {
>       "Host/stale_config" : 0,
>       "Host/maintenance_state" : 0,
>       "Host/host_state/HEALTHY" : 4,
>       "Host/host_state/UNHEALTHY" : 0,
>       "Host/host_state/HEARTBEAT_LOST" : 0,
>       "Host/host_state/INIT" : 0,
>       "Host/host_status/HEALTHY" : 0,
>       "Host/host_status/UNHEALTHY" : 1,
>       "Host/host_status/UNKNOWN" : 0,
>       "Host/host_status/ALERT" : 3
>     },
>     "total_hosts" : 4,
>     "version" : "HDP-2.3"
>   },
>   "alerts_summary_hosts" : {
>     "CRITICAL" : 0,
>     "OK" : 4,
>     "UNKNOWN" : 0,
>     "WARNING" : 0
>   }
> }
> {code}
> {code}
> "CRITICAL" : 0,
> "WARNING" : 0
> {code}
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/orm/dao/AlertsDAO.java 39b12c4 
> 
> Diff: https://reviews.apache.org/r/38679/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>