You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "rubenada (via GitHub)" <gi...@apache.org> on 2026/06/15 11:01:18 UTC
[PR] [CALCITE-7605] Add threat model [calcite]
rubenada opened a new pull request, #5020:
URL: https://github.com/apache/calcite/pull/5020
<!--
Thanks for sending a pull request! Here are some critical tips for you:
1. READ THE GUIDE FIRST: https://calcite.apache.org/develop/#contributing
*For significant contributions, please discuss on the dev mailing list or Jira BEFORE coding.*
2. JIRA IS USUALLY MANDATORY: Ensure you have created an issue on the Calcite Jira:
https://issues.apache.org/jira/projects/CALCITE/issues
*Check existing issues first to avoid duplicates.*
*Note: A Jira is NOT required for typos and cosmetic changes (i.e., changes that are neither bugs nor features).*
3. TIMING: Strongly recommended to create the Jira BEFORE you start writing code (e.g., a day or so before posting a PR).
This gives others a chance to weigh in on your specification.
4. CRITICAL CONSISTENCY RULE
The following three items MUST match exactly in wording and meaning:
(A) The Jira Issue Title
(B) This Pull Request Title
(C) Your Git Commit Message
Format: [CALCITE-XXXX] <Description>
Example: [CALCITE-0000] Add IF NOT EXISTS clause to CREATE TABLE
Guidelines for a good Title:
- Illustrate using SQL keywords (in ALL-CAPS) rather than Java method names.
- Focus on the specification and user experience, not the implementation.
- Make it clear whether it is a bug or a feature.
- Use words like "should" to indicate desired behavior vs. current behavior (e.g., "Validator should not close model file").
5. REPRODUCTION: If fixing a bug, please provide a concise SQL example or test case to reproduce the issue for a faster review.
6. TESTING: Ensure `./gradlew build` passes and appropriate tests are added/updated.
-->
## Jira Link
[CALCITE-7605] Add threat model
## Changes Proposed
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR.
-->
Add security threat model.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7605] Add threat model [calcite]
Posted by "rubenada (via GitHub)" <gi...@apache.org>.
rubenada closed pull request #5020: [CALCITE-7605] Add threat model
URL: https://github.com/apache/calcite/pull/5020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7605] Add threat model [calcite]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #5020:
URL: https://github.com/apache/calcite/pull/5020#issuecomment-5035271935
Sorry for missing it before - looking at it now !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7605] Add threat model [calcite]
Posted by "rubenada (via GitHub)" <gi...@apache.org>.
rubenada commented on PR #5020:
URL: https://github.com/apache/calcite/pull/5020#issuecomment-4718022576
@vlsi I have tried to combine here the initial drafts that we discussed on the email thread.
Should we ping someone from Apache security to help us out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7605] Add threat model [calcite]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #5020:
URL: https://github.com/apache/calcite/pull/5020#issuecomment-5035431457
Thanks @rubenada for driving this and combining the initial drafts. I read both this and #5115 against the threat-model rubric — the normative core (attacker model, P1–P4, the surprising-vs-unsurprising class-loading rule) is the same in both, and #5115 consolidates it a bit tighter: it drops the STRIDE table (which carried a couple of internal tensions — pushed-down SQL injection framed as both in- and out-of-scope, and the Janino/UDF row describing the boundary as input-sanitization rather than the actual class-loading gate), reframes DoS as a hardening goal rather than per-report vulnerabilities, and splits the concrete sink list into a separate living doc.
Since you've already offered to move forward with @vlsi's #5115, that reads as the right call to me too — so this one can probably be closed in favor of #5115. I've layered three additive suggestions on top of #5115 — an inputs table, a downstream-responsibilities section, and a closed triage-disposition set — in vlsi/calcite#3, for you both to take or leave.
Thanks again for pushing this forward — the model's in good shape.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7605] Add threat model [calcite]
Posted by "rubenada (via GitHub)" <gi...@apache.org>.
rubenada commented on PR #5020:
URL: https://github.com/apache/calcite/pull/5020#issuecomment-5035530346
Thanks @vlsi and @potiuk for the suggestions.
As agreed, closing this in favor of https://github.com/apache/calcite/pull/5115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7605] Add threat model [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #5020:
URL: https://github.com/apache/calcite/pull/5020#issuecomment-4707641801
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5020) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5020&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=5020&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=5020&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5020&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=5020&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=5020)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7605] Add threat model [calcite]
Posted by "rubenada (via GitHub)" <gi...@apache.org>.
rubenada commented on PR #5020:
URL: https://github.com/apache/calcite/pull/5020#issuecomment-4913799303
@potiuk , if you have a bit of time, could you please take a quick look at this draft? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7605] Add threat model [calcite]
Posted by "rubenada (via GitHub)" <gi...@apache.org>.
rubenada commented on PR #5020:
URL: https://github.com/apache/calcite/pull/5020#issuecomment-5034978489
Thanks @vlsi ! No problem at all. I'm happy to move this forward with your PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7605] Add threat model [calcite]
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi commented on PR #5020:
URL: https://github.com/apache/calcite/pull/5020#issuecomment-5034380228
I opened #5115 as an alternative draft for the same Jira.
It reorganizes the same normative content (attacker model, P1–P4, the class-loading rule, DoS goals) rather than replacing it, and makes two structural changes I found easier to review as a whole diff than as inline comments here:
- the concrete class-loading sinks move to a separate living document, so a new CVE updates that inventory and not the ratified model;
- the STRIDE table and the ASCII diagram are dropped — the reasoning is in the PR description.
This isn't meant to compete with your PR. Whichever framing the PMC prefers, I'm happy to fold the pieces back into #5020 instead. Interested in your take.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org