You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by andreaturli <gi...@git.apache.org> on 2015/01/30 10:13:33 UTC
[GitHub] incubator-brooklyn pull request: fix maven javac purity on JDK7
GitHub user andreaturli opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/493
fix maven javac purity on JDK7
- fix for CAMP module: some setters on the builders were breaking the build with javac
- it also fixes javac compiler in intellij
@ahgittin and @neykov can you have a look?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andreaturli/incubator-brooklyn fix/maven-pure-javac
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/493.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #493
----
commit d4ecbe7e7190b504461645ace6c7242c57418e9b
Author: Andrea Turli <an...@gmail.com>
Date: 2015-01-30T09:10:55Z
fix maven javac purity on JDK7
it also fix javac compiler in intellij
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fix maven javac purity on JDK7
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/493
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fix maven javac purity on JDK7
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/493#issuecomment-72190408
Looks good; merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fix maven javac purity on JDK7
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/493#discussion_r23831549
--- Diff: camp/camp-base/src/main/java/io/brooklyn/camp/spi/AbstractResource.java ---
@@ -94,66 +93,66 @@ public RepresentationSkew getRepresentationSkew() {
public Map<String, Object> getCustomAttributes() {
return ImmutableMap.copyOf(customAttributes);
}
-
+
// setters
- private void setId(String id) {
+ void setId(String id) {
this.id = id;
}
- private void setName(String name) {
+ void setName(String name) {
this.name = name;
}
- private void setDescription(String description) {
+ void setDescription(String description) {
this.description = description;
}
- private void setSourceCode(String sourceCode) {
+ void setSourceCode(String sourceCode) {
this.sourceCode = sourceCode;
}
- private void setCreated(Date created) {
+ void setCreated(Date created) {
// precision beyond seconds breaks equals check
this.created = Time.dropMilliseconds(created);
}
- private void setTags(List<String> tags) {
+ void setTags(List<String> tags) {
this.tags = ImmutableList.copyOf(tags);
}
- private void setType(String type) {
+ void setType(String type) {
this.type = type;
}
- private void setRepresentationSkew(RepresentationSkew representationSkew) {
+ void setRepresentationSkew(RepresentationSkew representationSkew) {
this.representationSkew = representationSkew;
}
- public void setCustomAttribute(String key, Object value) {
+ void setCustomAttribute(String key, Object value) {
--- End diff --
Did you decrease the visibiliby from `public` on purpose?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: fix maven javac purity on JDK7
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/493#discussion_r23833260
--- Diff: camp/camp-base/src/main/java/io/brooklyn/camp/spi/AbstractResource.java ---
@@ -94,66 +93,66 @@ public RepresentationSkew getRepresentationSkew() {
public Map<String, Object> getCustomAttributes() {
return ImmutableMap.copyOf(customAttributes);
}
-
+
// setters
- private void setId(String id) {
+ void setId(String id) {
this.id = id;
}
- private void setName(String name) {
+ void setName(String name) {
this.name = name;
}
- private void setDescription(String description) {
+ void setDescription(String description) {
this.description = description;
}
- private void setSourceCode(String sourceCode) {
+ void setSourceCode(String sourceCode) {
this.sourceCode = sourceCode;
}
- private void setCreated(Date created) {
+ void setCreated(Date created) {
// precision beyond seconds breaks equals check
this.created = Time.dropMilliseconds(created);
}
- private void setTags(List<String> tags) {
+ void setTags(List<String> tags) {
this.tags = ImmutableList.copyOf(tags);
}
- private void setType(String type) {
+ void setType(String type) {
this.type = type;
}
- private void setRepresentationSkew(RepresentationSkew representationSkew) {
+ void setRepresentationSkew(RepresentationSkew representationSkew) {
this.representationSkew = representationSkew;
}
- public void setCustomAttribute(String key, Object value) {
+ void setCustomAttribute(String key, Object value) {
--- End diff --
not sure it is needed to have `public` here, but happy to revert.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---