You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/05/04 20:24:20 UTC
[GitHub] [kafka] vvcephei commented on a change in pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms
vvcephei commented on a change in pull request #8596:
URL: https://github.com/apache/kafka/pull/8596#discussion_r419705427
##########
File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java
##########
@@ -877,7 +877,7 @@
public static final String STREAMS_METADATA_STATE_FOR_PARTITION_ASSIGNOR = "__streams.metadata.state.instance__";
public static final String STREAMS_ADMIN_CLIENT = "__streams.admin.client.instance__";
public static final String ASSIGNMENT_ERROR_CODE = "__assignment.error.code__";
- public static final String NEXT_PROBING_REBALANCE_MS = "__next.probing.rebalance.ms__";
+ public static final String NEXT_SCHEDULED_REBALANCE_MS = "__next.probing.rebalance.ms__";
Review comment:
Did you want to change the config key as well? I think this should be ok, since it's only used to pass state from one object to another within the same instance, so there should be no compatibility concern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org