You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Prasad Mujumdar (JIRA)" <ji...@apache.org> on 2011/08/20 00:19:27 UTC
[jira] [Created] (HIVE-2398) Hive server doesn't return schema for
'set' command
Hive server doesn't return schema for 'set' command
---------------------------------------------------
Key: HIVE-2398
URL: https://issues.apache.org/jira/browse/HIVE-2398
Project: Hive
Issue Type: Bug
Components: Server Infrastructure
Affects Versions: 0.7.1, 0.8.0
Reporter: Prasad Mujumdar
Assignee: Prasad Mujumdar
The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2398) Hive server doesn't return schema
for 'set' command
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104817#comment-13104817 ]
jiraposter@reviews.apache.org commented on HIVE-2398:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1605/
-----------------------------------------------------------
(Updated 2011-09-14 19:41:13.647029)
Review request for hive and Carl Steinbach.
Changes
-------
Added check for resultset non empty.
The full "set -v" output would be too long, also most of the rows will different in each test setup. Hence I am suggesting not to do that. Let me know if you disagree.
Summary
-------
The Hive server currently has the framework to process the Cli commands like 'set'. But it returns an empty schema definition for these resultsets. The patch here is to add a getSchema() to the CommandResponse interface. The SetProcessor is modified to build a schema object which is returned with getSchema.
HiveServer is modified to call the getSchema for command cases as well.
This addresses bug HIVE-2398.
https://issues.apache.org/jira/browse/HIVE-2398
Diffs (updated)
-----
jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java e744d11
ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java 4f7f472
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 9ca5ca4
service/src/java/org/apache/hadoop/hive/service/HiveServer.java 95f322a
Diff: https://reviews.apache.org/r/1605/diff
Testing
-------
Tested with ODBC program to execute the set command. Ran Hive unit tests.
Thanks,
Prasad
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Attachments: HIVE-2398.patch, HIVE-2398.patch
>
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2398) Hive server doesn't return schema for
'set' command
Posted by "Prasad Mujumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar updated HIVE-2398:
----------------------------------
Fix Version/s: 0.8.0
Status: Patch Available (was: Open)
Review request - https://reviews.apache.org/r/1605/
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: 0.8.0
>
> Attachments: HIVE-2398.patch
>
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2398) Hive server doesn't return schema
for 'set' command
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13102909#comment-13102909 ]
jiraposter@reviews.apache.org commented on HIVE-2398:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1605/#review1857
-----------------------------------------------------------
Please add a testcase. Also, I tried running 'set -v' from the CLI after setting hive.cli.print.header=true, and I don't see the column name in the output. This seems like a bug?
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
<https://reviews.apache.org/r/1605/#comment4245>
Checkstyle: static final variable names should appear in ALL CAPS
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
<https://reviews.apache.org/r/1605/#comment4248>
bld? Might be good to change the name to getSchema. Also, since setColName is a constant there's no need for this method to have an input parameter.
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
<https://reviews.apache.org/r/1605/#comment4247>
Please add static imports for STRING_TYPE_NAME, SERIALIZATION_NULL_FORMAT, and defaultNullString.
service/src/java/org/apache/hadoop/hive/service/HiveServer.java
<https://reviews.apache.org/r/1605/#comment4249>
This comment is no longer valid. Also, it might be cleaner to remove the else clause.
- Carl
On 2011-08-19 22:37:45, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1605/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-08-19 22:37:45)
bq.
bq.
bq. Review request for hive and Carl Steinbach.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The Hive server currently has the framework to process the Cli commands like 'set'. But it returns an empty schema definition for these resultsets. The patch here is to add a getSchema() to the CommandResponse interface. The SetProcessor is modified to build a schema object which is returned with getSchema.
bq. HiveServer is modified to call the getSchema for command cases as well.
bq.
bq.
bq. This addresses bug HIVE-2398.
bq. https://issues.apache.org/jira/browse/HIVE-2398
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java 4f7f472
bq. ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 97fa1ab
bq. service/src/java/org/apache/hadoop/hive/service/HiveServer.java c4b041f
bq.
bq. Diff: https://reviews.apache.org/r/1605/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested with ODBC program to execute the set command. Ran Hive unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Attachments: HIVE-2398.patch
>
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2398) Hive server doesn't return schema for
'set' command
Posted by "Prasad Mujumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar updated HIVE-2398:
----------------------------------
Attachment: HIVE-2398.patch
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: 0.8.0
>
> Attachments: HIVE-2398.patch
>
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2398) Hive server doesn't return schema for
'set' command
Posted by "Prasad Mujumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar updated HIVE-2398:
----------------------------------
Attachment: HIVE-2398.patch.1
New patch that with changes per review comments.
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Attachments: HIVE-2398.patch, HIVE-2398.patch, HIVE-2398.patch.1
>
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2398) Hive server doesn't return schema for
'set' command
Posted by "Prasad Mujumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar updated HIVE-2398:
----------------------------------
Attachment: HIVE-2398.patch
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Attachments: HIVE-2398.patch, HIVE-2398.patch
>
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2398) Hive server doesn't return schema for
'set' command
Posted by "Prasad Mujumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar updated HIVE-2398:
----------------------------------
Attachment: HIVE-2398.patch.2
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Attachments: HIVE-2398.patch, HIVE-2398.patch, HIVE-2398.patch.1, HIVE-2398.patch.2
>
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2398) Hive server doesn't return schema
for 'set' command
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104738#comment-13104738 ]
jiraposter@reviews.apache.org commented on HIVE-2398:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1605/#review1895
-----------------------------------------------------------
jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java
<https://reviews.apache.org/r/1605/#comment4376>
Need to assert that the size of the resultset is > 0. Might also be good to log the contents of the resultset.
- Carl
On 2011-09-13 20:03:48, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1605/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-13 20:03:48)
bq.
bq.
bq. Review request for hive and Carl Steinbach.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The Hive server currently has the framework to process the Cli commands like 'set'. But it returns an empty schema definition for these resultsets. The patch here is to add a getSchema() to the CommandResponse interface. The SetProcessor is modified to build a schema object which is returned with getSchema.
bq. HiveServer is modified to call the getSchema for command cases as well.
bq.
bq.
bq. This addresses bug HIVE-2398.
bq. https://issues.apache.org/jira/browse/HIVE-2398
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java e744d11
bq. ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java 4f7f472
bq. ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 9ca5ca4
bq. service/src/java/org/apache/hadoop/hive/service/HiveServer.java 95f322a
bq.
bq. Diff: https://reviews.apache.org/r/1605/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested with ODBC program to execute the set command. Ran Hive unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Attachments: HIVE-2398.patch, HIVE-2398.patch
>
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2398) Hive server doesn't return schema
for 'set' command
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104986#comment-13104986 ]
jiraposter@reviews.apache.org commented on HIVE-2398:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1605/#review1903
-----------------------------------------------------------
Ship it!
+1. Will commit if tests pass.
- Carl
On 2011-09-14 19:41:13, Prasad Mujumdar wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/1605/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-09-14 19:41:13)
bq.
bq.
bq. Review request for hive and Carl Steinbach.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The Hive server currently has the framework to process the Cli commands like 'set'. But it returns an empty schema definition for these resultsets. The patch here is to add a getSchema() to the CommandResponse interface. The SetProcessor is modified to build a schema object which is returned with getSchema.
bq. HiveServer is modified to call the getSchema for command cases as well.
bq.
bq.
bq. This addresses bug HIVE-2398.
bq. https://issues.apache.org/jira/browse/HIVE-2398
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java e744d11
bq. ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java 4f7f472
bq. ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 9ca5ca4
bq. service/src/java/org/apache/hadoop/hive/service/HiveServer.java 95f322a
bq.
bq. Diff: https://reviews.apache.org/r/1605/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested with ODBC program to execute the set command. Ran Hive unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Prasad
bq.
bq.
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Attachments: HIVE-2398.patch, HIVE-2398.patch, HIVE-2398.patch.1
>
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2398) Hive server doesn't return schema
for 'set' command
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105807#comment-13105807 ]
Hudson commented on HIVE-2398:
------------------------------
Integrated in Hive-trunk-h0.21 #957 (See [https://builds.apache.org/job/Hive-trunk-h0.21/957/])
HIVE-2398. Hive server doesn't return schema for 'set' command (Prasad Mujumdar via cws)
cws : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1171253
Files :
* /hive/trunk/jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
* /hive/trunk/service/src/java/org/apache/hadoop/hive/service/HiveServer.java
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: 0.9.0
>
> Attachments: HIVE-2398.patch, HIVE-2398.patch, HIVE-2398.patch.1, HIVE-2398.patch.2
>
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2398) Hive server doesn't return schema for
'set' command
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2398:
---------------------------------
Fix Version/s: (was: 0.8.0)
Status: Open (was: Patch Available)
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Attachments: HIVE-2398.patch
>
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2398) Hive server doesn't return schema
for 'set' command
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103945#comment-13103945 ]
jiraposter@reviews.apache.org commented on HIVE-2398:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1605/
-----------------------------------------------------------
(Updated 2011-09-13 20:03:48.343559)
Review request for hive and Carl Steinbach.
Changes
-------
Changes per review comments.
Added a JDBC test.
The CLI behaviour does look like a but. The JDBC and ODBC client are working fine, but CLI is not printing the header. I will go ahead and log a separate Jira for that.
Summary
-------
The Hive server currently has the framework to process the Cli commands like 'set'. But it returns an empty schema definition for these resultsets. The patch here is to add a getSchema() to the CommandResponse interface. The SetProcessor is modified to build a schema object which is returned with getSchema.
HiveServer is modified to call the getSchema for command cases as well.
This addresses bug HIVE-2398.
https://issues.apache.org/jira/browse/HIVE-2398
Diffs (updated)
-----
jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java e744d11
ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java 4f7f472
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 9ca5ca4
service/src/java/org/apache/hadoop/hive/service/HiveServer.java 95f322a
Diff: https://reviews.apache.org/r/1605/diff
Testing
-------
Tested with ODBC program to execute the set command. Ran Hive unit tests.
Thanks,
Prasad
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Attachments: HIVE-2398.patch
>
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2398) Hive server doesn't return schema for
'set' command
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2398:
---------------------------------
Resolution: Fixed
Fix Version/s: 0.9.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks Prasad!
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Fix For: 0.9.0
>
> Attachments: HIVE-2398.patch, HIVE-2398.patch, HIVE-2398.patch.1, HIVE-2398.patch.2
>
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2398) Hive server doesn't return schema for
'set' command
Posted by "Prasad Mujumdar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Prasad Mujumdar updated HIVE-2398:
----------------------------------
Status: Patch Available (was: Open)
HIVE-2398.patch.1 is the new patch
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
> Attachments: HIVE-2398.patch, HIVE-2398.patch, HIVE-2398.patch.1
>
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2398) Hive server doesn't return schema
for 'set' command
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088036#comment-13088036 ]
jiraposter@reviews.apache.org commented on HIVE-2398:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1605/
-----------------------------------------------------------
Review request for hive and Carl Steinbach.
Summary
-------
The Hive server currently has the framework to process the Cli commands like 'set'. But it returns an empty schema definition for these resultsets. The patch here is to add a getSchema() to the CommandResponse interface. The SetProcessor is modified to build a schema object which is returned with getSchema.
HiveServer is modified to call the getSchema for command cases as well.
This addresses bug HIVE-2398.
https://issues.apache.org/jira/browse/HIVE-2398
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorResponse.java 4f7f472
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java 97fa1ab
service/src/java/org/apache/hadoop/hive/service/HiveServer.java c4b041f
Diff: https://reviews.apache.org/r/1605/diff
Testing
-------
Tested with ODBC program to execute the set command. Ran Hive unit tests.
Thanks,
Prasad
> Hive server doesn't return schema for 'set' command
> ---------------------------------------------------
>
> Key: HIVE-2398
> URL: https://issues.apache.org/jira/browse/HIVE-2398
> Project: Hive
> Issue Type: Bug
> Components: Server Infrastructure
> Affects Versions: 0.7.1, 0.8.0
> Reporter: Prasad Mujumdar
> Assignee: Prasad Mujumdar
>
> The Hive server does process the CLI commands like 'set', 'set -v' sent by ODBC or JDBC clients. But currently only the data is returned to client but not schema for that resultset. This makes it unusable for a ODBC or JDBC client to use this option.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira