You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stu Hood (JIRA)" <ji...@apache.org> on 2011/02/09 09:09:57 UTC
[jira] Created: (CASSANDRA-2145) Simplify ColumnSortedMap
Simplify ColumnSortedMap
------------------------
Key: CASSANDRA-2145
URL: https://issues.apache.org/jira/browse/CASSANDRA-2145
Project: Cassandra
Issue Type: Improvement
Reporter: Stu Hood
Assignee: Stu Hood
We can simplify ColumnSortedMap substantially by hijacking the shell of another sorted map implementation, rather than having scads of methods implemented as "UnsupportedOperation"s.
Also, CASSANDRA-679 needs a way to feed a supercolumn an arbitrary sorted iterator, rather than necessarily deserializing.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2145) Simplify ColumnSortedMap
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-2145:
--------------------------------
Attachment: 0001-CASSANDRA-2145-Extract-serialization-from-ColumnSorted.txt
Rebased and simplified a bit more. I'd be fine with going back to the skeleton approach, but IMO a -250 line delta is nothing to shake a stick at.
> Simplify ColumnSortedMap
> ------------------------
>
> Key: CASSANDRA-2145
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2145
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 1.0
>
> Attachments: 0001-CASSANDRA-2145-Extract-serialization-from-ColumnSorted.txt
>
>
> We can simplify ColumnSortedMap substantially by hijacking the shell of another sorted map implementation, rather than having scads of methods implemented as "UnsupportedOperation"s.
> Also, CASSANDRA-674 needs a way to feed a supercolumn an arbitrary sorted iterator, rather than necessarily deserializing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2145) Simplify ColumnSortedMap
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-2145:
--------------------------------
Attachment: 0001-CASSANDRA-2145-Extract-serialization-from-ColumnSorted.txt
Guts TreeMap as the shell SortedMap implementation (without ever actually storing anything in the map), and moves serialization specific tasks into SuperColumn so that we can feed an arbitrary iterator to its constructor.
> Simplify ColumnSortedMap
> ------------------------
>
> Key: CASSANDRA-2145
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2145
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Fix For: 0.7.2
>
> Attachments: 0001-CASSANDRA-2145-Extract-serialization-from-ColumnSorted.txt
>
>
> We can simplify ColumnSortedMap substantially by hijacking the shell of another sorted map implementation, rather than having scads of methods implemented as "UnsupportedOperation"s.
> Also, CASSANDRA-674 needs a way to feed a supercolumn an arbitrary sorted iterator, rather than necessarily deserializing.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2145) Simplify ColumnSortedMap
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-2145:
--------------------------------
Component/s: Core
Description:
We can simplify ColumnSortedMap substantially by hijacking the shell of another sorted map implementation, rather than having scads of methods implemented as "UnsupportedOperation"s.
Also, CASSANDRA-674 needs a way to feed a supercolumn an arbitrary sorted iterator, rather than necessarily deserializing.
was:
We can simplify ColumnSortedMap substantially by hijacking the shell of another sorted map implementation, rather than having scads of methods implemented as "UnsupportedOperation"s.
Also, CASSANDRA-679 needs a way to feed a supercolumn an arbitrary sorted iterator, rather than necessarily deserializing.
Fix Version/s: 0.7.2
> Simplify ColumnSortedMap
> ------------------------
>
> Key: CASSANDRA-2145
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2145
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Fix For: 0.7.2
>
>
> We can simplify ColumnSortedMap substantially by hijacking the shell of another sorted map implementation, rather than having scads of methods implemented as "UnsupportedOperation"s.
> Also, CASSANDRA-674 needs a way to feed a supercolumn an arbitrary sorted iterator, rather than necessarily deserializing.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2145) Simplify ColumnSortedMap
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-2145:
--------------------------------
Attachment: (was: 0001-CASSANDRA-2145-Extract-serialization-from-ColumnSorted.txt)
> Simplify ColumnSortedMap
> ------------------------
>
> Key: CASSANDRA-2145
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2145
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 1.0
>
>
> We can simplify ColumnSortedMap substantially by hijacking the shell of another sorted map implementation, rather than having scads of methods implemented as "UnsupportedOperation"s.
> Also, CASSANDRA-674 needs a way to feed a supercolumn an arbitrary sorted iterator, rather than necessarily deserializing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2145) Simplify ColumnSortedMap
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-2145:
--------------------------------
Attachment: (was: 0001-CASSANDRA-2145-Extract-serialization-from-ColumnSorted.txt)
> Simplify ColumnSortedMap
> ------------------------
>
> Key: CASSANDRA-2145
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2145
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Priority: Minor
>
> We can simplify ColumnSortedMap substantially by hijacking the shell of another sorted map implementation, rather than having scads of methods implemented as "UnsupportedOperation"s.
> Also, CASSANDRA-674 needs a way to feed a supercolumn an arbitrary sorted iterator, rather than necessarily deserializing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2145) Simplify ColumnSortedMap
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-2145:
----------------------------------------
Fix Version/s: (was: 0.7.2)
0.7.3
> Simplify ColumnSortedMap
> ------------------------
>
> Key: CASSANDRA-2145
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2145
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Fix For: 0.7.3
>
> Attachments: 0001-CASSANDRA-2145-Extract-serialization-from-ColumnSorted.txt
>
>
> We can simplify ColumnSortedMap substantially by hijacking the shell of another sorted map implementation, rather than having scads of methods implemented as "UnsupportedOperation"s.
> Also, CASSANDRA-674 needs a way to feed a supercolumn an arbitrary sorted iterator, rather than necessarily deserializing.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (CASSANDRA-2145) Simplify ColumnSortedMap
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2145:
--------------------------------------
Priority: Minor (was: Major)
Fix Version/s: (was: 0.7.4)
0.8
I don't agree that inheriting a complex class with lots of side effects is simpler than implementing a skeleton class with just the needed functionality. Pushing to 0.8 for the 674 requirements.
> Simplify ColumnSortedMap
> ------------------------
>
> Key: CASSANDRA-2145
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2145
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Fix For: 0.8
>
> Attachments: 0001-CASSANDRA-2145-Extract-serialization-from-ColumnSorted.txt
>
>
> We can simplify ColumnSortedMap substantially by hijacking the shell of another sorted map implementation, rather than having scads of methods implemented as "UnsupportedOperation"s.
> Also, CASSANDRA-674 needs a way to feed a supercolumn an arbitrary sorted iterator, rather than necessarily deserializing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2145) Simplify ColumnSortedMap
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-2145:
--------------------------------
Attachment: 0001-CASSANDRA-2145-Extract-serialization-from-ColumnSorted.txt
bq. Still prefer simplicity of design to raw loc as the right metric to apply here.
Ok, I yield... nonetheless, posting one last rebasing of the old style.
> Simplify ColumnSortedMap
> ------------------------
>
> Key: CASSANDRA-2145
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2145
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Stu Hood
> Priority: Minor
> Attachments: 0001-CASSANDRA-2145-Extract-serialization-from-ColumnSorted.txt
>
>
> We can simplify ColumnSortedMap substantially by hijacking the shell of another sorted map implementation, rather than having scads of methods implemented as "UnsupportedOperation"s.
> Also, CASSANDRA-674 needs a way to feed a supercolumn an arbitrary sorted iterator, rather than necessarily deserializing.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira