You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "codecov-io (GitHub)" <gi...@apache.org> on 2018/11/01 09:59:12 UTC
[GitHub] [incubator-dubbo] codecov-io commented on issue #2725: [DUBBO-2525]: Problems of graceful shutdown in 2.6.3 and some recommendation

# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2725?src=pr&el=h1) Report
> Merging [#2725](https://codecov.io/gh/apache/incubator-dubbo/pull/2725?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/c21cc05ec9ff4f96f34af9027714bb525cd0edf5?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `68.18%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dubbo/pull/2725/graphs/tree.svg?width=650&token=VnEIkiFQT0&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dubbo/pull/2725?src=pr&el=tree)

```diff
@@            Coverage Diff             @@
##           master    #2725      +/-   ##
==========================================
- Coverage    63.6%   63.53%   -0.07%     
==========================================
  Files         580      576       -4     
  Lines       25978    25918      -60     
  Branches     4541     4538       -3     
==========================================
- Hits        16523    16467      -56     
+ Misses       7292     7291       -1     
+ Partials     2163     2160       -3
```


| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2725?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/dubbo/config/ProtocolConfig.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2725/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9Qcm90b2NvbENvbmZpZy5qYXZh) | `75.18% <ø> (+1.11%)` | :arrow_up: |
| [...va/org/apache/dubbo/config/spring/ServiceBean.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2725/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvU2VydmljZUJlYW4uamF2YQ==) | `49.57% <100%> (+1.91%)` | :arrow_up: |
| [...onfig/spring/extension/SpringExtensionFactory.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2725/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvZXh0ZW5zaW9uL1NwcmluZ0V4dGVuc2lvbkZhY3RvcnkuamF2YQ==) | `80.55% <100%> (-5.66%)` | :arrow_down: |
| [...apache/dubbo/container/spring/SpringContainer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2725/diff?src=pr&el=tree#diff-ZHViYm8tY29udGFpbmVyL2R1YmJvLWNvbnRhaW5lci1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbnRhaW5lci9zcHJpbmcvU3ByaW5nQ29udGFpbmVyLmphdmE=) | `70.58% <100%> (-4.42%)` | :arrow_down: |
| [...che/dubbo/config/spring/util/BeanFactoryUtils.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2725/diff?src=pr&el=tree#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvdXRpbC9CZWFuRmFjdG9yeVV0aWxzLmphdmE=) | `66.66% <41.66%> (-25%)` | :arrow_down: |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2725/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | :arrow_down: |
| [...ubbo/rpc/protocol/dubbo/ChannelWrappedInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2725/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL0NoYW5uZWxXcmFwcGVkSW52b2tlci5qYXZh) | `41.66% <0%> (-8.34%)` | :arrow_down: |
| [.../apache/dubbo/qos/protocol/QosProtocolWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2725/diff?src=pr&el=tree#diff-ZHViYm8tcGx1Z2luL2R1YmJvLXFvcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcW9zL3Byb3RvY29sL1Fvc1Byb3RvY29sV3JhcHBlci5qYXZh) | `65.78% <0%> (-5.27%)` | :arrow_down: |
| [...he/dubbo/remoting/transport/netty/NettyServer.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2725/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9uZXR0eS9OZXR0eVNlcnZlci5qYXZh) | `67.85% <0%> (-3.58%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2725/diff?src=pr&el=tree-more) | |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2725?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2725?src=pr&el=footer). Last update [c21cc05...595b04d](https://codecov.io/gh/apache/incubator-dubbo/pull/2725?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2725 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org