You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by iw...@apache.org on 2016/06/14 10:29:20 UTC
hadoop git commit: HADOOP-13244. o.a.h.ipc.Server#Server should honor
handlerCount when queueSizePerHandler is specified in consturctor.
Contributed by Kai Sasaki.
Repository: hadoop
Updated Branches:
refs/heads/trunk ee55b74fb -> 20b13d109
HADOOP-13244. o.a.h.ipc.Server#Server should honor handlerCount when queueSizePerHandler is specified in consturctor. Contributed by Kai Sasaki.
Project: http://git-wip-us.apache.org/repos/asf/hadoop/repo
Commit: http://git-wip-us.apache.org/repos/asf/hadoop/commit/20b13d10
Tree: http://git-wip-us.apache.org/repos/asf/hadoop/tree/20b13d10
Diff: http://git-wip-us.apache.org/repos/asf/hadoop/diff/20b13d10
Branch: refs/heads/trunk
Commit: 20b13d109a1f66d8911936d26bdde38d81a1c4c6
Parents: ee55b74
Author: Masatake Iwasaki <iw...@apache.org>
Authored: Tue Jun 14 19:20:46 2016 +0900
Committer: Masatake Iwasaki <iw...@apache.org>
Committed: Tue Jun 14 19:20:46 2016 +0900
----------------------------------------------------------------------
.../src/main/java/org/apache/hadoop/ipc/Server.java | 2 +-
.../src/test/java/org/apache/hadoop/ipc/TestRPC.java | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hadoop/blob/20b13d10/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
index 88c1f3c..caa534c 100644
--- a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
+++ b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
@@ -2553,7 +2553,7 @@ public abstract class Server {
this.maxDataLength = conf.getInt(CommonConfigurationKeys.IPC_MAXIMUM_DATA_LENGTH,
CommonConfigurationKeys.IPC_MAXIMUM_DATA_LENGTH_DEFAULT);
if (queueSizePerHandler != -1) {
- this.maxQueueSize = queueSizePerHandler;
+ this.maxQueueSize = handlerCount * queueSizePerHandler;
} else {
this.maxQueueSize = handlerCount * conf.getInt(
CommonConfigurationKeys.IPC_SERVER_HANDLER_QUEUE_SIZE_KEY,
http://git-wip-us.apache.org/repos/asf/hadoop/blob/20b13d10/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
----------------------------------------------------------------------
diff --git a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
index dbc9430..ff6b25e 100644
--- a/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
+++ b/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestRPC.java
@@ -348,6 +348,10 @@ public class TestRPC extends TestRpcBase {
assertEquals(3, server.getNumReaders());
assertEquals(200, server.getMaxQueueSize());
+
+ server = newServerBuilder(conf).setQueueSizePerHandler(10)
+ .setNumHandlers(2).setVerbose(false).build();
+ assertEquals(2 * 10, server.getMaxQueueSize());
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org