You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by je...@apache.org on 2015/04/03 12:52:30 UTC

thrift git commit: THRIFT-3066 C++ TDenseProtocol assert modifies instead of checks Client: C++ Patch: James E. King, III

Repository: thrift
Updated Branches:
  refs/heads/master 4aa95df38 -> 434edf6d5


THRIFT-3066 C++ TDenseProtocol assert modifies instead of checks
Client: C++
Patch: James E. King, III <ji...@simplivity.com>


Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/434edf6d
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/434edf6d
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/434edf6d

Branch: refs/heads/master
Commit: 434edf6d5d5f9705c1ebf3f711fd7e1b8efbb40d
Parents: 4aa95df
Author: Jens Geyer <je...@apache.org>
Authored: Fri Apr 3 12:52:01 2015 +0200
Committer: Jens Geyer <je...@apache.org>
Committed: Fri Apr 3 12:52:01 2015 +0200

----------------------------------------------------------------------
 lib/cpp/src/thrift/protocol/TDenseProtocol.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/thrift/blob/434edf6d/lib/cpp/src/thrift/protocol/TDenseProtocol.cpp
----------------------------------------------------------------------
diff --git a/lib/cpp/src/thrift/protocol/TDenseProtocol.cpp b/lib/cpp/src/thrift/protocol/TDenseProtocol.cpp
index d6644b7..583b630 100644
--- a/lib/cpp/src/thrift/protocol/TDenseProtocol.cpp
+++ b/lib/cpp/src/thrift/protocol/TDenseProtocol.cpp
@@ -155,7 +155,7 @@ inline void TDenseProtocol::stateTransition() {
   // If this is the end of the top-level write, we should have just popped
   // the TypeSpec passed to the constructor.
   if (ts_stack_.empty()) {
-    assert(old_tts = type_spec_);
+    assert(old_tts == type_spec_);
     return;
   }