You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/03/28 07:32:14 UTC

[GitHub] [servicecomb-java-chassis] GuoYL123 opened a new pull request #1674: support kie enable

GuoYL123 opened a new pull request #1674: support kie enable
URL: https://github.com/apache/servicecomb-java-chassis/pull/1674
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1674: support kie enable

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1674: support kie enable
URL: https://github.com/apache/servicecomb-java-chassis/pull/1674#discussion_r399910658
 
 

 ##########
 File path: dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/model/KVDoc.java
 ##########
 @@ -23,7 +23,7 @@
 
 public class KVDoc {
 
-  @JsonAlias("_id")
+  @JsonAlias("id")
 
 Review comment:
   Can be deleted

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] coveralls commented on issue #1674: support kie enable

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1674: support kie enable
URL: https://github.com/apache/servicecomb-java-chassis/pull/1674#issuecomment-606981487
 
 
   
   [![Coverage Status](https://coveralls.io/builds/29757510/badge)](https://coveralls.io/builds/29757510)
   
   Coverage decreased (-0.006%) to 84.963% when pulling **9439bddb0afe9b4ad1a3514aa023a03444caa5db on GuoYL123:kie-s** into **a5355e71219a09e6f4a0bc68bf877fea6a4e94b9 on apache:master**.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #1674: support kie enable

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #1674: support kie enable
URL: https://github.com/apache/servicecomb-java-chassis/pull/1674#discussion_r399911673
 
 

 ##########
 File path: dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/client/KieUtil.java
 ##########
 @@ -50,6 +50,8 @@
 
   private static final String LABEL_VERSION = "version";
 
+  private static final String STATUS_ENABLE = "enabled";
 
 Review comment:
   STATUS_ENABLED

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] GuoYL123 commented on a change in pull request #1674: support kie enable

Posted by GitBox <gi...@apache.org>.
GuoYL123 commented on a change in pull request #1674: support kie enable
URL: https://github.com/apache/servicecomb-java-chassis/pull/1674#discussion_r400845443
 
 

 ##########
 File path: dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/model/KVDoc.java
 ##########
 @@ -23,7 +23,7 @@
 
 public class KVDoc {
 
-  @JsonAlias("_id")
+  @JsonAlias("id")
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #1674: [SCB-1851] config-kie: support enable property

Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #1674: [SCB-1851] config-kie: support enable property
URL: https://github.com/apache/servicecomb-java-chassis/pull/1674
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [servicecomb-java-chassis] GuoYL123 commented on a change in pull request #1674: support kie enable

Posted by GitBox <gi...@apache.org>.
GuoYL123 commented on a change in pull request #1674: support kie enable
URL: https://github.com/apache/servicecomb-java-chassis/pull/1674#discussion_r400845514
 
 

 ##########
 File path: dynamic-config/config-kie/src/main/java/org/apache/servicecomb/config/kie/client/KieUtil.java
 ##########
 @@ -50,6 +50,8 @@
 
   private static final String LABEL_VERSION = "version";
 
+  private static final String STATUS_ENABLE = "enabled";
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services