You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Ekaterina Dimitrova (Jira)" <ji...@apache.org> on 2021/11/10 23:28:00 UTC

[jira] [Comment Edited] (CASSANDRA-17132) Fix startup issue with internode_application_timeout_in_ms

    [ https://issues.apache.org/jira/browse/CASSANDRA-17132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17442001#comment-17442001 ] 

Ekaterina Dimitrova edited comment on CASSANDRA-17132 at 11/10/21, 11:27 PM:
-----------------------------------------------------------------------------

Thank you for confirming [~benedict] .

I just realized we also don't need _otc_coalescing_enough_coalesced_messages._

It is only used to check whether it is between 0 and 128 in the _DatabaseDescriptor_ and nothing else. I removed that check and the parameter too.

[4.0 patch |https://github.com/ekaterinadimitrova2/cassandra/pull/new/17132-4.0] | [J8 CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1188/workflows/06afaf5b-6951-4b3d-8fbf-6ef2aef04e52] | [J11 CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1188/workflows/8b8d24bc-b24e-439a-92e3-d6f4541ef9fb]

[trunk patch |https://github.com/ekaterinadimitrova2/cassandra/pull/new/17132-trunk] | [J8 CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1189/workflows/416dcd5e-720e-4eca-b3d5-61767906457b] | [J11 CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1189/workflows/40cb1de6-299d-4c6a-a162-d878d79beb67]

The docs are still in transition so I will open a followup ticket to update them in ascidoc. 


was (Author: e.dimitrova):
I just realized we also don't need _otc_coalescing_enough_coalesced_messages._

It is only used to check whether it is between 0 and 128 in the _DatabaseDescriptor_ and nothing else. I removed that check and the parameter too.

[4.0 patch |https://github.com/ekaterinadimitrova2/cassandra/pull/new/17132-4.0] | [J8 CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1188/workflows/06afaf5b-6951-4b3d-8fbf-6ef2aef04e52] | [J11 CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1188/workflows/8b8d24bc-b24e-439a-92e3-d6f4541ef9fb]

[trunk patch |https://github.com/ekaterinadimitrova2/cassandra/pull/new/17132-trunk] | [J8 CI |https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1189/workflows/416dcd5e-720e-4eca-b3d5-61767906457b] | [J11 CI|https://app.circleci.com/pipelines/github/ekaterinadimitrova2/cassandra/1189/workflows/40cb1de6-299d-4c6a-a162-d878d79beb67]

The docs are still in transition so I will open a followup ticket to update them in ascidoc. 

> Fix startup issue with internode_application_timeout_in_ms
> ----------------------------------------------------------
>
>                 Key: CASSANDRA-17132
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17132
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Build
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 4.0.x, 4.x
>
>
> While testing my patch for CASSANDRA-17131 I found that there is a problem with _internode_application_timeout_in_ms_ in 4.0 and trunk.
> Seems to me that we can just safely remove it for now?



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org