You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/05/15 13:50:45 UTC
Review Request 67130: Updated comments related to `wait`,
`destroy` containerizer methods.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67130/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang.
Bugs: MESOS-8740
https://issues.apache.org/jira/browse/MESOS-8740
Repository: mesos
Description
-------
This patch updates description of `wait()` and `destroy()` methods
of the containerizer API.
Diffs
-----
src/slave/containerizer/containerizer.hpp 5817b1dfacd02d818d867ddf214ba316182ebedc
Diff: https://reviews.apache.org/r/67130/diff/1/
Testing
-------
None: not a functional change.
Thanks,
Andrei Budnik
Re: Review Request 67130: Updated comments related to `wait`,
`destroy` containerizer methods.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67130/#review203564
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/containerizer/containerizer.hpp
Line 131 (original), 131 (patched)
<https://reviews.apache.org/r/67130/#comment285849>
Can we just remove this line?
- Qian Zhang
On May 15, 2018, 9:50 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67130/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 9:50 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang.
>
>
> Bugs: MESOS-8740
> https://issues.apache.org/jira/browse/MESOS-8740
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates description of `wait()` and `destroy()` methods
> of the containerizer API.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp 5817b1dfacd02d818d867ddf214ba316182ebedc
>
>
> Diff: https://reviews.apache.org/r/67130/diff/2/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 67130: Updated comments related to `wait`,
`destroy` containerizer methods.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67130/#review203780
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On May 15, 2018, 1:50 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67130/
> -----------------------------------------------------------
>
> (Updated May 15, 2018, 1:50 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Greg Mann, Jie Yu, and Qian Zhang.
>
>
> Bugs: MESOS-8740
> https://issues.apache.org/jira/browse/MESOS-8740
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch updates description of `wait()` and `destroy()` methods
> of the containerizer API.
>
>
> Diffs
> -----
>
> src/slave/containerizer/containerizer.hpp 5817b1dfacd02d818d867ddf214ba316182ebedc
>
>
> Diff: https://reviews.apache.org/r/67130/diff/4/
>
>
> Testing
> -------
>
> None: not a functional change.
>
>
> Thanks,
>
> Andrei Budnik
>
>