You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:39:33 UTC
[GitHub] [nifi] gresockj opened a new pull request #5146: NIFI-8643: Correcting nifi.cluster.load.balance.address in properties
gresockj opened a new pull request #5146:
URL: https://github.com/apache/nifi/pull/5146
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
#### Description of PR
Since the code looks for nifi.cluster.load.balance.address but nifi.cluster.load.balance.host is specified in the documentation and nifi.properties file, the load balancer is always bound to localhost. This corrects the properties and documentation.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 merged pull request #5146: NIFI-8643: Correcting nifi.cluster.load.balance.address in properties
Posted by GitBox <gi...@apache.org>.
markap14 merged pull request #5146:
URL: https://github.com/apache/nifi/pull/5146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] JensMKofoed commented on pull request #5146: NIFI-8643: Correcting nifi.cluster.load.balance.address in properties
Posted by GitBox <gi...@apache.org>.
JensMKofoed commented on pull request #5146:
URL: https://github.com/apache/nifi/pull/5146#issuecomment-860588269
Hi
When I typed in a fqdn as the nifi.cluster.load.balance.address is still bind to localhost. I had to type in the IP address or 0.0.0.0.
So the property name address seems to correspond to an actual ip address. If the property name was host I will assume it would be a fqdn.
If I have multiple network interfaces on my nodes, I would select one interface (ip address) to be the network for load balance and another for the remote access UI and S2S.
Using fqdn as host property will not provide you the possibility to select a different network for internal load balance between nodes. Therefore I will go for the address property and specified that it has to be an ip address
Kind Regards
Jens M. Kofoed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #5146: NIFI-8643: Correcting nifi.cluster.load.balance.address in properties
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #5146:
URL: https://github.com/apache/nifi/pull/5146#issuecomment-859874889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] gresockj commented on pull request #5146: NIFI-8643: Correcting nifi.cluster.load.balance.address in properties
Posted by GitBox <gi...@apache.org>.
gresockj commented on pull request #5146:
URL: https://github.com/apache/nifi/pull/5146#issuecomment-859478327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org