You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2017/03/23 20:32:45 UTC
Review Request 57891: Added a new unmocked method to the mock agent.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57891/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Bugs: MESOS-6999
https://issues.apache.org/jira/browse/MESOS-6999
Repository: mesos
Description
-------
This patch adds a new method to the mock agent,
`MockSlave::unmocked_executorTerminated`. This will
facilitate the testing of executor secret generation,
as it allows us to forward the mock function call to
the base class method.
Diffs
-----
src/tests/mock_slave.hpp 1acb961b642e1e0b4677db7b8fc6150d480eb751
src/tests/mock_slave.cpp 50c04bff9e6f0f202af4c07b4036e021d3833ebf
Diff: https://reviews.apache.org/r/57891/diff/1/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 57891: Added a new unmocked method to the mock
agent.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57891/
-----------------------------------------------------------
(Updated March 24, 2017, 9:30 p.m.)
Review request for mesos, Anand Mazumdar and Vinod Kone.
Changes
-------
Rebase.
Bugs: MESOS-6999
https://issues.apache.org/jira/browse/MESOS-6999
Repository: mesos
Description
-------
This patch adds a new method to the mock agent,
`MockSlave::unmocked_executorTerminated`. This will
facilitate the testing of executor secret generation,
as it allows us to forward the mock function call to
the base class method.
Diffs (updated)
-----
src/tests/mock_slave.hpp 1acb961b642e1e0b4677db7b8fc6150d480eb751
src/tests/mock_slave.cpp 50c04bff9e6f0f202af4c07b4036e021d3833ebf
Diff: https://reviews.apache.org/r/57891/diff/2/
Changes: https://reviews.apache.org/r/57891/diff/1-2/
Testing
-------
Testing details can be found at the end of this chain.
Thanks,
Greg Mann
Re: Review Request 57891: Added a new unmocked method to the mock
agent.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57891/#review170026
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Mazumdar
On March 23, 2017, 8:32 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57891/
> -----------------------------------------------------------
>
> (Updated March 23, 2017, 8:32 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Bugs: MESOS-6999
> https://issues.apache.org/jira/browse/MESOS-6999
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a new method to the mock agent,
> `MockSlave::unmocked_executorTerminated`. This will
> facilitate the testing of executor secret generation,
> as it allows us to forward the mock function call to
> the base class method.
>
>
> Diffs
> -----
>
> src/tests/mock_slave.hpp 1acb961b642e1e0b4677db7b8fc6150d480eb751
> src/tests/mock_slave.cpp 50c04bff9e6f0f202af4c07b4036e021d3833ebf
>
>
> Diff: https://reviews.apache.org/r/57891/diff/1/
>
>
> Testing
> -------
>
> Testing details can be found at the end of this chain.
>
>
> Thanks,
>
> Greg Mann
>
>