You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by "Karl Heinz Marbaise (Jira)" <ji...@apache.org> on 2019/10/12 08:56:00 UTC

[jira] [Commented] (MNG-6777) Remove duplicate resolveFile methods

    [ https://issues.apache.org/jira/browse/MNG-6777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949967#comment-16949967 ] 

Karl Heinz Marbaise commented on MNG-6777:
------------------------------------------

Done in [877fcc9cd585bd89b42911a07e65ebefe1d83718|https://gitbox.apache.org/repos/asf?p=maven.git;a=commitdiff;h=877fcc9cd585bd89b42911a07e65ebefe1d83718]

> Remove duplicate resolveFile methods
> ------------------------------------
>
>                 Key: MNG-6777
>                 URL: https://issues.apache.org/jira/browse/MNG-6777
>             Project: Maven
>          Issue Type: Task
>          Components: Embedding
>    Affects Versions: 3.6.3
>            Reporter: Anatoly Zaretsky
>            Priority: Trivial
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Both org.apache.maven.cli.MavenCli and org.apache.maven.cli.configuration.SettingsXmlConfigurationProcessor contain identical package-private static methods called resolveFile - they can be replaced with the new public class org.apache.maven.cli.ResolveFile with the single public static method resolveFile. Also it would be more appropriate to rename workingDirectory parameter to baseDirectory.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)