You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/01/04 15:53:21 UTC
[GitHub] [solr] dweiss commented on a change in pull request #491: SOLR-15867 Bring in build stuff from lucene
dweiss commented on a change in pull request #491:
URL: https://github.com/apache/solr/pull/491#discussion_r778190251
##########
File path: solr/docker/build.gradle
##########
@@ -67,8 +67,9 @@ dependencies {
builtBy 'assemblePackaging'
}
- solrTgz project(path: ":solr:packaging", configuration: 'solrTgz')
- solrTgzSignature project(path: ":solr:packaging", configuration: 'solrTgzSignature')
+ // NOCOMMIT: Fix the reference to solr:distribution
+ solrTgz project(path: ":solr:distribution:", configuration: 'solrTgz')
Review comment:
Typically the distribution is the end-node. Here it's not - you need to add artifacts to a named configuration on the distribution project, then that configuration will be resolvable and consumable in docker. Grep for "artifacts {" blocks - this essentially links a task (and its outputs) or an explicit path + build task to a named configuration, which can be then consumed elsewhere. Here the solrTgz configuration was previously exposed this way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org