You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/04 03:10:20 UTC

[GitHub] [arrow] jacques-n commented on a change in pull request #7329: ARROW-9016: [Java] Remove direct references to Netty/Unsafe Allocators

jacques-n commented on a change in pull request #7329:
URL: https://github.com/apache/arrow/pull/7329#discussion_r434966944



##########
File path: java/memory/src/main/java/org/apache/arrow/memory/DefaultAllocationManagerOption.java
##########
@@ -85,14 +87,32 @@ static AllocationManagerType getDefaultAllocationManagerType() {
 
     switch (type) {
       case Netty:

Review comment:
       Let's do a follow-on where we change this from type to class name for the factory. That way we don't have weird strings in here. The implementations can all have the default factory class.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org