You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/06/28 19:48:27 UTC
[GitHub] marcoabreu commented on a change in pull request #11467:
[MXNET-591] fix flaky test_loss.test_ctc_loss_train
marcoabreu commented on a change in pull request #11467: [MXNET-591] fix flaky test_loss.test_ctc_loss_train
URL: https://github.com/apache/incubator-mxnet/pull/11467#discussion_r198963834
##########
File path: tests/python/unittest/test_loss.py
##########
@@ -180,8 +180,7 @@ def test_l1_loss():
assert mod.score(data_iter, eval_metric=mx.metric.Loss())[0][1] < 0.1
-@unittest.skip("flaky test. https://github.com/apache/incubator-mxnet/issues/8892")
-@with_seed()
+@with_seed(1234)
Review comment:
Please don't fix the seed if possible
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services