[jira] [Commented] (MESOS-4125) Use 'git rev-parse --git-dir' instead of assuming '.git' in top dir

["Shuai Lin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067457#comment-15067457 ] 

Shuai Lin commented on MESOS-4125:
----------------------------------

It would be great if the git multiple worktrees feature could also be supported. When git multiple worktree feature is in effect (See [MESOS-4216]), The output of {{git rev-parse --git-dir}} is like this:

{code}
$ cd ~/mesos-new-branch
$ git rev-parse --git-dir
~/mesos/.git/worktrees/mesos-doc
$ ls ~/mesos/.git/worktrees/mesos-doc
COMMIT_EDITMSG  commondir  FETCH_HEAD  gitdir  HEAD  index  logs  ORIG_HEAD
{code}

There is no {{hooks/}} directory in the gitdir of the "mesos-new-branch" worktree. 


> Use 'git rev-parse --git-dir' instead of assuming '.git' in top dir
> -------------------------------------------------------------------
>
>                 Key: MESOS-4125
>                 URL: https://issues.apache.org/jira/browse/MESOS-4125
>             Project: Mesos
>          Issue Type: Improvement
>          Components: build
>         Environment: All systems
>            Reporter: Kevin Klues
>            Assignee: Kevin Klues
>            Priority: Minor
>              Labels: bootstrap, build, mesosphere
>
> This issue relates to files where we assume that mesos's '.git' folder is always located in the top level directory of the mesos tree.
> For example, bootstrap makes this assumption.  Specifically, it attempts to install pre-commit and post-rewrite hooks into the hardcoded .git/hooks directory. However, it is not always true that the .git folder is located here.
> Most notably, it is not true if the mesos tree is included as a submodule inside another project. When included as a submodule, .git is no longer a directory, but rather a file whose text contains a pointer back to the actual location of the .git folder inside the containing project.  To get at this directory, we need to run 'git rev-parse --git-dir' instead of simply assuming that the local .git is the proper directory.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)