You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Milesian111 (via GitHub)" <gi...@apache.org> on 2025/02/24 11:46:33 UTC
[PR] [FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters [flink]
Milesian111 opened a new pull request, #26201:
URL: https://github.com/apache/flink/pull/26201
[FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
This pull request dealt with a "TODO" at class "SqlNodeToOperationConversion", method "convertValidatedSqlNode":
"TODO: all the below conversion logic should be migrated to SqlNodeConverters".
And I migrated over 40 of converters to SqlNodeConverters.
## Brief change log
- *The Sql conversion logic codes are all migrated from SqlNodeToOperationConversion to SqlNodeConverters *
## Verifying this change
This change is already covered by existing tests, such as *SqlDdlToOperationConverterTest* and *SqlDmlToOperationConverterTest* .
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters [flink]
Posted by "Milesian111 (via GitHub)" <gi...@apache.org>.
Milesian111 commented on PR #26201:
URL: https://github.com/apache/flink/pull/26201#issuecomment-2680212576
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26201:
URL: https://github.com/apache/flink/pull/26201#issuecomment-2954778817
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #26201: [FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters
URL: https://github.com/apache/flink/pull/26201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters [flink]
Posted by "Milesian111 (via GitHub)" <gi...@apache.org>.
Milesian111 commented on PR #26201:
URL: https://github.com/apache/flink/pull/26201#issuecomment-2712463428
@schulzp @alpinegizmo @aljoscha @rmetzger @reswqa @mtfelisb @rmetzger Is there anyone who will review my code? Thank you very much!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters [flink]
Posted by "Milesian111 (via GitHub)" <gi...@apache.org>.
Milesian111 commented on PR #26201:
URL: https://github.com/apache/flink/pull/26201#issuecomment-2680255738
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26201:
URL: https://github.com/apache/flink/pull/26201#issuecomment-2678233323
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "d02d4fc3e5ad285ea05fc6b9f0abcc563b5842bd",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "d02d4fc3e5ad285ea05fc6b9f0abcc563b5842bd",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* d02d4fc3e5ad285ea05fc6b9f0abcc563b5842bd UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters [flink]
Posted by "Milesian111 (via GitHub)" <gi...@apache.org>.
Milesian111 commented on PR #26201:
URL: https://github.com/apache/flink/pull/26201#issuecomment-2680283499
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26201:
URL: https://github.com/apache/flink/pull/26201#issuecomment-3055792044
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-37357][table-planner]Migrating SqlNode conversion logic from SqlNodeToOperationConversion to SqlNodeConverters [flink]
Posted by "Milesian111 (via GitHub)" <gi...@apache.org>.
Milesian111 commented on PR #26201:
URL: https://github.com/apache/flink/pull/26201#issuecomment-2680202136
@flinkbot run azure re-run the last Azure build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org