You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2018/08/30 13:16:11 UTC

[GitHub] kolodgrz commented on a change in pull request #1150: log/shell: Add support for logging cbor logs in shell

kolodgrz commented on a change in pull request #1150: log/shell: Add support for logging cbor logs in shell
URL: https://github.com/apache/mynewt-core/pull/1150#discussion_r214025524
 
 

 ##########
 File path: sys/log/full/src/log_shell.c
 ##########
 @@ -44,6 +47,12 @@ shell_log_dump_entry(struct log *log, struct log_offset *log_offset,
     char data[128];
 
 Review comment:
   @vrahane this is not a change in this PR. I can add separate patch to this PR with adoption of this log data size - @vrahane have any idea how big it should be ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services