You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/07/11 00:16:49 UTC
Re: Review Request 60331: Windows: Disable code using `os::shell()`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60331/#review180110
-----------------------------------------------------------
Ship it!
I'll disable that new flag:
src/slave/main.cpp
Lines 299-309 (original), 299-314 (patched)
<https://reviews.apache.org/r/60331/#comment255156>
Since this patch was made, a `--ip6_discovery_command` was added which also needs to be disabled.
- Joseph Wu
On June 21, 2017, 4:52 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60331/
> -----------------------------------------------------------
>
> (Updated June 21, 2017, 4:52 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and Michael Park.
>
>
> Bugs: MESOS-6817, MESOS-7371 and MESOS-7407
> https://issues.apache.org/jira/browse/MESOS-6817
> https://issues.apache.org/jira/browse/MESOS-7371
> https://issues.apache.org/jira/browse/MESOS-7407
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The disabled tests were already disabled, but at runtime instead of
> compile time. Deleting `os::shell()` forces us to temporarily disable
> the IP discovery command flag until we can move the implementation of
> `subprocess()` into stout.
>
>
> Diffs
> -----
>
> src/slave/main.cpp 66ae7db4039eedba7ff4eff51495384317c09354
> src/tests/fetcher_tests.cpp 99149baa1c7abfabf572a0d0f4512a8e84d1e5be
>
>
> Diff: https://reviews.apache.org/r/60331/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>