You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rsafonseca <gi...@git.apache.org> on 2015/06/21 14:05:26 UTC
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
GitHub user rsafonseca opened a pull request:
https://github.com/apache/cloudstack/pull/497
Attempt to resolve ovm3 jenkins failure
Resolve unsafe cast warnings reported by lint checker
Add some debug config to compiler plugin
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rsafonseca/cloudstack fixjenkinsovm3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/497.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #497
----
commit 611c98bd8f2d3ff890998ed13512f6d4f10d315d
Author: Rafael da Fonseca <rs...@gmail.com>
Date: 2015-06-21T12:03:53Z
Resolve unsafe cast warnings reported by lint checker
Add some debug config to compiler plugin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/497#issuecomment-113956319
@bhaisaab you can go ahead and merge now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/497#issuecomment-113955383
Victory!
One of the problem nodes just compiled it successfully and ran until the end without problems
Will now get started on cleaning up the PR and just leave the fix and a couple other minor improvements made along the way
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/497#issuecomment-114054951
@karuturi done in a nicer way, as requested :)
FYI, the only thing that is needed to actually fix the ovm3 problem is the changes to plugins/hypervisors/ovm3/src/test/java/com/cloud/hypervisor/ovm3/objects/XenTest.java
All the rest are just minor improvements made along the testing of the problem, but none are related to actually fixing it. The minor improvements i referred to are simply getting rid of some lint checker warnings about serializable classes not having the serialversionuid and doing redundant explicit casts. Also added a couple of non declared dependencies to the pom, and that's it :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/497#issuecomment-113935237
Looks like you've got it @rsafonseca please squash the commits all 50+ of 'em :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/497#discussion_r32905987
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
<relativePath>../../pom.xml</relativePath>
</parent>
<dependencies>
-<dependency>
- <groupId>org.apache.xmlrpc</groupId>
- <artifactId>xmlrpc-client</artifactId>
- <version>3.1.3</version>
-</dependency>
+ <dependency>
+ <groupId>xml-apis</groupId>
+ <artifactId>xml-apis</artifactId>
+ <version>1.4.01</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.xmlrpc</groupId>
+ <artifactId>xmlrpc-client</artifactId>
+ <version>3.1.3</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.xmlrpc</groupId>
+ <artifactId>xmlrpc-common</artifactId>
+ <version>3.1.3</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>3.4</version>
--- End diff --
can you add this version to parent pom and use from there?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/497#discussion_r32905983
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
<relativePath>../../pom.xml</relativePath>
</parent>
<dependencies>
-<dependency>
- <groupId>org.apache.xmlrpc</groupId>
- <artifactId>xmlrpc-client</artifactId>
- <version>3.1.3</version>
-</dependency>
+ <dependency>
+ <groupId>xml-apis</groupId>
+ <artifactId>xml-apis</artifactId>
+ <version>1.4.01</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.xmlrpc</groupId>
+ <artifactId>xmlrpc-client</artifactId>
+ <version>3.1.3</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.xmlrpc</groupId>
+ <artifactId>xmlrpc-common</artifactId>
+ <version>3.1.3</version>
--- End diff --
Can we resuse the version number(cs.xmlrpc.version) from parent pom?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/497#discussion_r32917853
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
<relativePath>../../pom.xml</relativePath>
</parent>
<dependencies>
-<dependency>
- <groupId>org.apache.xmlrpc</groupId>
- <artifactId>xmlrpc-client</artifactId>
- <version>3.1.3</version>
-</dependency>
+ <dependency>
+ <groupId>xml-apis</groupId>
+ <artifactId>xml-apis</artifactId>
+ <version>1.4.01</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.xmlrpc</groupId>
+ <artifactId>xmlrpc-client</artifactId>
+ <version>3.1.3</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.xmlrpc</groupId>
+ <artifactId>xmlrpc-common</artifactId>
+ <version>3.1.3</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>3.4</version>
--- End diff --
I can, will do. We should also upgrade some other components to lang3 as lang is outdated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/497#issuecomment-113937925
Just as i said travis was stable, got a lot of failures haha :)
Upon looking into it, travis didn't fail, it is correctly reporting that i killed ovm3 lol, so travis fix is working as expected.. this PR is the one who isn't
Will fix soon, i can now reproduce the issue locally :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/497#discussion_r32906046
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
<relativePath>../../pom.xml</relativePath>
</parent>
<dependencies>
-<dependency>
- <groupId>org.apache.xmlrpc</groupId>
- <artifactId>xmlrpc-client</artifactId>
- <version>3.1.3</version>
-</dependency>
+ <dependency>
+ <groupId>xml-apis</groupId>
+ <artifactId>xml-apis</artifactId>
--- End diff --
this is a new dependency. Is this conflict resolution? If yes, can this be added to the exclusion list of the dependency?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/497#discussion_r32905980
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
<relativePath>../../pom.xml</relativePath>
</parent>
<dependencies>
-<dependency>
- <groupId>org.apache.xmlrpc</groupId>
- <artifactId>xmlrpc-client</artifactId>
- <version>3.1.3</version>
-</dependency>
+ <dependency>
+ <groupId>xml-apis</groupId>
+ <artifactId>xml-apis</artifactId>
+ <version>1.4.01</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.xmlrpc</groupId>
+ <artifactId>xmlrpc-client</artifactId>
+ <version>3.1.3</version>
--- End diff --
Can we resuse the version number(cs.xmlrpc.version) from parent pom?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/497
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/497#discussion_r32905996
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
<relativePath>../../pom.xml</relativePath>
</parent>
<dependencies>
-<dependency>
- <groupId>org.apache.xmlrpc</groupId>
- <artifactId>xmlrpc-client</artifactId>
- <version>3.1.3</version>
-</dependency>
+ <dependency>
+ <groupId>xml-apis</groupId>
+ <artifactId>xml-apis</artifactId>
+ <version>1.4.01</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.xmlrpc</groupId>
+ <artifactId>xmlrpc-client</artifactId>
+ <version>3.1.3</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.xmlrpc</groupId>
+ <artifactId>xmlrpc-common</artifactId>
+ <version>3.1.3</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>3.4</version>
+ </dependency>
+ <dependency>
+ <groupId>log4j</groupId>
+ <artifactId>log4j</artifactId>
+ <version>1.2.17</version>
--- End diff --
Can we reuse cs.log4j.version from parent pom?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on the pull request:
https://github.com/apache/cloudstack/pull/497#issuecomment-113935738
Hi Rohit,
Sorry for spamming you guys so hard this weekend eheh :)
I've found the problem, but it's still not properly fixed. Cause seems to
be a 20k+ string in XenTest.java
Gave me some work to make that a StringBuilder instead of just adding
strings.. this should use a lot less heap and cpu, but now it seems to be
failing consistently, although build doesn't stop because i've put a flag
on the compiler plugin to continue anyway.
Will squash the whole thing when i get all SUCCESS instead of UNSTABLE ;)
Although 0 travis failures so far.. yay for the other fix hehe
On Sun, Jun 21, 2015 at 7:47 PM, Rohit Yadav <no...@github.com>
wrote:
> Looks like you've got it @rsafonseca <https://github.com/rsafonseca>
> please squash the commits all 50+ of 'em :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cloudstack/pull/497#issuecomment-113935237>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/497#issuecomment-114435233
Thanks for the update @rsafonseca
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/497#discussion_r32917768
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
<relativePath>../../pom.xml</relativePath>
</parent>
<dependencies>
-<dependency>
- <groupId>org.apache.xmlrpc</groupId>
- <artifactId>xmlrpc-client</artifactId>
- <version>3.1.3</version>
-</dependency>
+ <dependency>
+ <groupId>xml-apis</groupId>
+ <artifactId>xml-apis</artifactId>
--- End diff --
It's not a new dependency, just an explicit declaration of something that was a dependency already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/497#discussion_r32917874
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
<relativePath>../../pom.xml</relativePath>
</parent>
<dependencies>
-<dependency>
- <groupId>org.apache.xmlrpc</groupId>
- <artifactId>xmlrpc-client</artifactId>
- <version>3.1.3</version>
-</dependency>
+ <dependency>
+ <groupId>xml-apis</groupId>
+ <artifactId>xml-apis</artifactId>
+ <version>1.4.01</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.xmlrpc</groupId>
+ <artifactId>xmlrpc-client</artifactId>
+ <version>3.1.3</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.xmlrpc</groupId>
+ <artifactId>xmlrpc-common</artifactId>
+ <version>3.1.3</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>3.4</version>
+ </dependency>
+ <dependency>
+ <groupId>log4j</groupId>
+ <artifactId>log4j</artifactId>
+ <version>1.2.17</version>
--- End diff --
We can, though this version is already pretty old and not likely to change, will update for consistency
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/497#discussion_r32917802
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
<relativePath>../../pom.xml</relativePath>
</parent>
<dependencies>
-<dependency>
- <groupId>org.apache.xmlrpc</groupId>
- <artifactId>xmlrpc-client</artifactId>
- <version>3.1.3</version>
-</dependency>
+ <dependency>
+ <groupId>xml-apis</groupId>
+ <artifactId>xml-apis</artifactId>
+ <version>1.4.01</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.xmlrpc</groupId>
+ <artifactId>xmlrpc-client</artifactId>
+ <version>3.1.3</version>
--- End diff --
We can and should, i just kept this one the way it was, version was already specified in the version currently in master, will update
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Attempt to resolve ovm3 jenkins failure
Posted by rsafonseca <gi...@git.apache.org>.
Github user rsafonseca commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/497#discussion_r32917814
--- Diff: plugins/hypervisors/ovm3/pom.xml ---
@@ -27,11 +27,31 @@
<relativePath>../../pom.xml</relativePath>
</parent>
<dependencies>
-<dependency>
- <groupId>org.apache.xmlrpc</groupId>
- <artifactId>xmlrpc-client</artifactId>
- <version>3.1.3</version>
-</dependency>
+ <dependency>
+ <groupId>xml-apis</groupId>
+ <artifactId>xml-apis</artifactId>
+ <version>1.4.01</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.xmlrpc</groupId>
+ <artifactId>xmlrpc-client</artifactId>
+ <version>3.1.3</version>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.xmlrpc</groupId>
+ <artifactId>xmlrpc-common</artifactId>
+ <version>3.1.3</version>
--- End diff --
Yes, will update
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---