[jira] [Commented] (MCOMPILER-243) Compiler Plugin's Documentation on Compiler Args Seems Wrong

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MCOMPILER-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14596935#comment-14596935 ] 

ASF GitHub Bot commented on MCOMPILER-243:
------------------------------------------

GitHub user pparkkin opened a pull request:

    https://github.com/apache/maven-plugins/pull/55

    [MCOMPILER-243] Place compilerArgs inside configuration.

    Documentation for compilerArgs is incorrect.
    
    See: http://maven.apache.org/plugins/maven-compiler-plugin/examples/pass-compiler-arguments.html
    
    The compilerArgs tag should be inside the configuration tags.
    
    This contribution is my original work and I license the work to the project under the project's open source license.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pparkkin/maven-plugins MCOMPILER-243

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-plugins/pull/55.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #55
    
----
commit 665828ae42446de99e9b8bae228932d7cdccb956
Author: Paavo <pp...@gmail.com>
Date:   2015-06-23T00:43:07Z

    Place compilerArgs inside configuration.

----


> Compiler Plugin's Documentation on Compiler Args Seems Wrong
> ------------------------------------------------------------
>
>                 Key: MCOMPILER-243
>                 URL: https://issues.apache.org/jira/browse/MCOMPILER-243
>             Project: Maven Compiler Plugin
>          Issue Type: Bug
>            Reporter: Tim Stewart
>            Assignee: Karl Heinz Marbaise
>            Priority: Trivial
>              Labels: compiler, docuentation
>
> On this page: 
>     http://maven.apache.org/plugins/maven-compiler-plugin/examples/pass-compiler-arguments.html
> I'm instructed to express compilerArgs this way:
>     <plugins>
>       <plugin>
>         <groupId>org.apache.maven.plugins</groupId>
>         <artifactId>maven-compiler-plugin</artifactId>
>         <version>3.3</version>
>         <compilerArgs>
>             <arg>-verbose</arg>
>             <arg>-Xlint:all,-options,-path</arg>
>           </compilerArgs>
>       </plugin>
>     </plugins>
> When I do that I get an error:
>     Unrecognised tag: 'compilerArgs' (position: START_TAG seen ...</configuration>\n            <compilerArgs>... @21:27) 
> But when I tuck the compilerArgs XML element under the configuration element, it works:
>         <plugin>
>           <groupId>org.apache.maven.plugins</groupId>
>           <artifactId>maven-compiler-plugin</artifactId>
>           <version>3.3</version>
>           <configuration>
>             <compilerArgs>
>               <arg>-verbose</arg>
>               <arg>-Xlint:all,-options,-path</arg>
>             </compilerArgs>
>             <source>1.8</source>
>             <target>1.8</target>
>           </configuration>
>         </plugin>



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)