You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/12/23 02:09:42 UTC
Review Request 55005: CMake: renamed `process_tests` to
`libprocess-tests` to match autotools.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55005/
-----------------------------------------------------------
Review request for mesos, Alex Clemmer and Joseph Wu.
Repository: mesos
Description
-------
See https://reviews.apache.org/r/55006/.
Diffs
-----
3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 9817426c3c924c7cd988d5bf4fd41b6a2fd4962a
3rdparty/libprocess/src/tests/CMakeLists.txt 4b80c397381ca2c869cd6eb7507bb9df94ce3623
Diff: https://reviews.apache.org/r/55005/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 55005: CMake: renamed `process_tests` to
`libprocess-tests` to match autotools.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55005/
-----------------------------------------------------------
(Updated Jan. 7, 2017, 12:13 a.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Changes
-------
Addressed Till's comment. Will decide what to do about `libprocess-tests` vs `process-tests` with feedback from Alex and Joseph.
Repository: mesos
Description (updated)
-------
CMake: renamed `process_tests` to `libprocess-tests` to match autotools.
Diffs (updated)
-----
3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 9817426c3c924c7cd988d5bf4fd41b6a2fd4962a
3rdparty/libprocess/src/tests/CMakeLists.txt 4b80c397381ca2c869cd6eb7507bb9df94ce3623
Diff: https://reviews.apache.org/r/55005/diff/
Testing
-------
Thanks,
Michael Park
Re: Review Request 55005: CMake: renamed `process_tests` to
`libprocess-tests` to match autotools.
Posted by Michael Park <mp...@apache.org>.
> On Jan. 5, 2017, 4 p.m., Alex Clemmer wrote:
> > 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake, line 20
> > <https://reviews.apache.org/r/55005/diff/1/?file=1591506#file1591506line20>
> >
> > As I said in response to Till's comment, I think it is better to call it `process-tests`. We specifically call it this because on Windows, there is no `libprocess`. There is only `process.lib`.
Synced with Alex on Slack: https://mesos.slack.com/archives/windows/p1483776572000827
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55005/#review160650
-----------------------------------------------------------
On Jan. 7, 2017, 12:13 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55005/
> -----------------------------------------------------------
>
> (Updated Jan. 7, 2017, 12:13 a.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake: renamed `process_tests` to `libprocess-tests` to match autotools.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 9817426c3c924c7cd988d5bf4fd41b6a2fd4962a
> 3rdparty/libprocess/src/tests/CMakeLists.txt 4b80c397381ca2c869cd6eb7507bb9df94ce3623
>
> Diff: https://reviews.apache.org/r/55005/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55005: CMake: renamed `process_tests` to
`libprocess-tests` to match autotools.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55005/#review160650
-----------------------------------------------------------
3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake (line 20)
<https://reviews.apache.org/r/55005/#comment231797>
As I said in response to Till's comment, I think it is better to call it `process-tests`. We specifically call it this because on Windows, there is no `libprocess`. There is only `process.lib`.
- Alex Clemmer
On Dec. 23, 2016, 2:09 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55005/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2016, 2:09 a.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See https://reviews.apache.org/r/55006/.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 9817426c3c924c7cd988d5bf4fd41b6a2fd4962a
> 3rdparty/libprocess/src/tests/CMakeLists.txt 4b80c397381ca2c869cd6eb7507bb9df94ce3623
>
> Diff: https://reviews.apache.org/r/55005/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55005: CMake: renamed `process_tests` to
`libprocess-tests` to match autotools.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Dec. 27, 2016, 1:14 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/src/tests/CMakeLists.txt, line 67
> > <https://reviews.apache.org/r/55005/diff/1/?file=1591507#file1591507line67>
> >
> > s/process-tests/libprocess-tests/ ?
I would say this is not necessary. On `libx` is a POSIX convention. For example, `libprocess.a` on POSIX would usually be `process.lib` on Windows.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55005/#review160156
-----------------------------------------------------------
On Dec. 23, 2016, 2:09 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55005/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2016, 2:09 a.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See https://reviews.apache.org/r/55006/.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 9817426c3c924c7cd988d5bf4fd41b6a2fd4962a
> 3rdparty/libprocess/src/tests/CMakeLists.txt 4b80c397381ca2c869cd6eb7507bb9df94ce3623
>
> Diff: https://reviews.apache.org/r/55005/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55005: CMake: renamed `process_tests` to
`libprocess-tests` to match autotools.
Posted by Joseph Wu <jo...@mesosphere.io>.
> On Dec. 27, 2016, 5:14 a.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/src/tests/CMakeLists.txt, line 67
> > <https://reviews.apache.org/r/55005/diff/1/?file=1591507#file1591507line67>
> >
> > s/process-tests/libprocess-tests/ ?
>
> Alex Clemmer wrote:
> I would say this is not necessary. On `libx` is a POSIX convention. For example, `libprocess.a` on POSIX would usually be `process.lib` on Windows.
This name is fine. The goal here is to match the autotools name, which creates a test binary called `libprocess-tests`. Library files will still get the appropriate name on Posix/Windows, as those names are mostly autogenerated by the build system.
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55005/#review160156
-----------------------------------------------------------
On Dec. 22, 2016, 6:09 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55005/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 6:09 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See https://reviews.apache.org/r/55006/.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 9817426c3c924c7cd988d5bf4fd41b6a2fd4962a
> 3rdparty/libprocess/src/tests/CMakeLists.txt 4b80c397381ca2c869cd6eb7507bb9df94ce3623
>
> Diff: https://reviews.apache.org/r/55005/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 55005: CMake: renamed `process_tests` to
`libprocess-tests` to match autotools.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55005/#review160156
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/src/tests/CMakeLists.txt (line 67)
<https://reviews.apache.org/r/55005/#comment231206>
s/process-tests/libprocess-tests/ ?
- Till Toenshoff
On Dec. 23, 2016, 2:09 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55005/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2016, 2:09 a.m.)
>
>
> Review request for mesos, Alex Clemmer and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See https://reviews.apache.org/r/55006/.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 9817426c3c924c7cd988d5bf4fd41b6a2fd4962a
> 3rdparty/libprocess/src/tests/CMakeLists.txt 4b80c397381ca2c869cd6eb7507bb9df94ce3623
>
> Diff: https://reviews.apache.org/r/55005/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>