You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/06 06:45:07 UTC

[GitHub] [skywalking-client-js] Fine0830 commented on pull request #45: add `originAllowlist` option

Fine0830 commented on pull request #45:
URL: https://github.com/apache/skywalking-client-js/pull/45#issuecomment-791884848


   There are some suggestions for this. 1. For the SDK name, could you change `originAllowlist ` to `NoTraceOrigins` and update the corresponding logic? 2. It is fine that the type of `originAllowlist` is `(string | RegExp)[]`. 3. the default value of `originAllowlist` is [].
   WDYT? @wu-sheng  @kezhenxu94 @tianyk 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org