You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Alok Lal <al...@hortonworks.com> on 2016/01/26 01:50:47 UTC

Re: Review Request 41374: Kafka plugin should build/work with the kafka v0.9 jar with authorization support that have been pushed to public repos

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41374/
-----------------------------------------------------------

(Updated Jan. 25, 2016, 4:50 p.m.)


Review request for ranger, Don Bosco Durai and Madhan Neethiraj.


Changes
-------

Last step of this change: removing the kafka-security maven profile all together.  We have given enough time to community to absorb an hollowed our profile.  As for the prior change, once approved, I'd push this out to 0.5 branch, too.


Bugs: RANGER-777
    https://issues.apache.org/jira/browse/RANGER-777


Repository: ranger


Description
-------

Since kafka's support for authorizer was not on master, building kafka plugin required some doing.  Kafka team has since released the authorization changes as part of the v0.9 jar that was pushed into maven central.  As part of that a few of the auxiliary APIs, related to authentication, that kafka plugin was relying on got changed. Accordingly, this patch:
- Changes kafka plugin code so it uses the APIs that are released as part of v0.9 kafka jar.
- Removes the need for special profile to build kafka plugin such that now it gets build by default if a complete build is done for kafka

These changes would be ported also port to 0.5.


Diffs (updated)
-----

  pom.xml 23ef49e 

Diff: https://reviews.apache.org/r/41374/diff/


Testing
-------

1. Kafka authorization for publish/consume works as before.
2. Authentication API changes were used by HDFS audit plugin.  Ensured that audit to HDFS works before and after use of new API.  Test was done against kafka cluster.


Thanks,

Alok Lal


Re: Review Request 41374: Kafka plugin should build/work with the kafka v0.9 jar with authorization support that have been pushed to public repos

Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41374/#review116245
-----------------------------------------------------------


Ship it!




Ship It!

- Madhan Neethiraj


On Jan. 26, 2016, 12:50 a.m., Alok Lal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41374/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2016, 12:50 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai and Madhan Neethiraj.
> 
> 
> Bugs: RANGER-777
>     https://issues.apache.org/jira/browse/RANGER-777
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Since kafka's support for authorizer was not on master, building kafka plugin required some doing.  Kafka team has since released the authorization changes as part of the v0.9 jar that was pushed into maven central.  As part of that a few of the auxiliary APIs, related to authentication, that kafka plugin was relying on got changed. Accordingly, this patch:
> - Changes kafka plugin code so it uses the APIs that are released as part of v0.9 kafka jar.
> - Removes the need for special profile to build kafka plugin such that now it gets build by default if a complete build is done for kafka
> 
> These changes would be ported also port to 0.5.
> 
> 
> Diffs
> -----
> 
>   pom.xml 23ef49e 
> 
> Diff: https://reviews.apache.org/r/41374/diff/
> 
> 
> Testing
> -------
> 
> 1. Kafka authorization for publish/consume works as before.
> 2. Authentication API changes were used by HDFS audit plugin.  Ensured that audit to HDFS works before and after use of new API.  Test was done against kafka cluster.
> 
> 
> Thanks,
> 
> Alok Lal
> 
>