You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "wangpeix (via GitHub)" <gi...@apache.org> on 2023/04/01 06:46:20 UTC

[GitHub] [inlong] wangpeix opened a new pull request, #7753: [Bug][Agent] PulsarSink threadPool throw reject exception

wangpeix opened a new pull request, #7753:
URL: https://github.com/apache/inlong/pull/7753

   ### Prepare a Pull Request
   - Title: [INLONG-7752][Agent] PulsarSink threadPool throw reject exception
   - Fixes #7752 
   
   ### Motivation
   
   Fix `PulsarSink` threadPool throw reject exception when  delete file data source on dashboard and then add  file data source.
   
   ### Modifications
   
   Do not shut down the global thread pool when destroy the `PulsarSink` of one task.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #7753: [INLONG-7752][Agent] PulsarSink threadPool throw reject exception

Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7753:
URL: https://github.com/apache/inlong/pull/7753#discussion_r1155531558


##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sinks/PulsarSink.java:
##########
@@ -196,7 +196,6 @@ public void destroy() {
             AgentUtils.silenceSleepInMs(batchFlushInterval);
         }
         shutdown = true;
-        EXECUTOR_SERVICE.shutdown();

Review Comment:
   Ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] wangpeix commented on a diff in pull request #7753: [INLONG-7752][Agent] PulsarSink threadPool throw reject exception

Posted by "wangpeix (via GitHub)" <gi...@apache.org>.
wangpeix commented on code in PR #7753:
URL: https://github.com/apache/inlong/pull/7753#discussion_r1155479247


##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sinks/PulsarSink.java:
##########
@@ -196,7 +196,6 @@ public void destroy() {
             AgentUtils.silenceSleepInMs(batchFlushInterval);
         }
         shutdown = true;
-        EXECUTOR_SERVICE.shutdown();

Review Comment:
   The `PulsarSink` thread pool is global and, based on the current design, will always exist throughout the agent's lifecycle. When closed, new tasks cannot be submitted to the thread pool; think it's okay not to shutdown it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #7753: [INLONG-7752][Agent] PulsarSink threadPool throw reject exception

Posted by "healchow (via GitHub)" <gi...@apache.org>.
healchow commented on code in PR #7753:
URL: https://github.com/apache/inlong/pull/7753#discussion_r1155337458


##########
inlong-agent/agent-plugins/src/main/java/org/apache/inlong/agent/plugin/sinks/PulsarSink.java:
##########
@@ -196,7 +196,6 @@ public void destroy() {
             AgentUtils.silenceSleepInMs(batchFlushInterval);
         }
         shutdown = true;
-        EXECUTOR_SERVICE.shutdown();

Review Comment:
   Then, when we shutdown this global thread pool?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] dockerzhang merged pull request #7753: [INLONG-7752][Agent] PulsarSink threadPool throw reject exception

Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #7753:
URL: https://github.com/apache/inlong/pull/7753


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org