You are viewing a plain text version of this content. The canonical link for it is here.

Posted to c-dev@axis.apache.org by Samisa Abeysinghe <sa...@gmail.com> on 2005/12/05 08:43:51 UTC

Re: [Axis2] COPYING file

hmm this is a *serious* mistake.

I have fixed this now. (applied to the Axis2C source tree)

Many thanks for pointing this out.

Thanks,
Samisa...

On 12/5/05, Anuradha Ratnaweera <gn...@gmail.com> wrote:
> Hi there,
>
> The license file c/COPYING is a link to
> /usr/share/automake-1.9/COPYING, which is GPL.  Isn't it rather
> Apache?  Since autoconf/automake requires a COPYING file, it would be
> a neat thing to replace the link with a copy of the Apache license...
>
>         Anuradha
> --
> http://anuradha-ratnaweera.blogspot.com
> http://www.linux.lk/~anuradha/
>

Re: [Axis2] Dealing with different versions of automake/atoconf

Posted by Damitha Kumarage <da...@gmail.com>.

Hi,

Anuradha Ratnaweera wrote:

>On 12/6/05, Samisa Abeysinghe <sa...@gmail.com> wrote:
>  
>
>>Given your expertise in the GNU make system, do you have any idea if
>>we can make our configure.ac work across different versions of
>>automake/autoconf?
>>
>>Basically the problem is that PHP uses autoconf 2.13 and automake
>>1.5 (PHP make system complains if the versions are not 2.13/1.5)
>>
>>Ours make use of autoconf 2.59 and automake 1.9 (our make system
>>fails if versions are not 2.59/1.9)
>>    
>>
system fails if versions are not later that 2.59/1.9

>>Can we write our configure.ac to work in these different version on
>>auto tools?
>>    
>>
>
>I think the best option would be to find out the least common
>denominator between the two different tools combination and remove the
>version dependancy _completely_.  We don't have to be very much
>backword compatible for anything earlier than 2.13/1.5.
>
>What are the reasons to mandate 2.59/1.9?
>
>      Anuradha
>--
>http://anuradha-ratnaweera.blogspot.com
>http://www.linux.lk/~anuradha/
>
>  
>

Re: [Axis2] Dealing with different versions of automake/atoconf

Posted by Samisa Abeysinghe <sa...@gmail.com>.

Anuradha Ratnaweera wrote:

>On 12/6/05, Samisa Abeysinghe <sa...@gmail.com> wrote:
>  
>
>>Given your expertise in the GNU make system, do you have any idea if
>>we can make our configure.ac work across different versions of
>>automake/autoconf?
>>
>>Basically the problem is that PHP uses autoconf 2.13 and automake
>>1.5 (PHP make system complains if the versions are not 2.13/1.5)
>>
>>Ours make use of autoconf 2.59 and automake 1.9 (our make system
>>fails if versions are not 2.59/1.9)
>>
>>Can we write our configure.ac to work in these different version on
>>auto tools?
>>    
>>
>
>I think the best option would be to find out the least common
>denominator between the two different tools combination and remove the
>version dependancy _completely_.  We don't have to be very much
>backword compatible for anything earlier than 2.13/1.5.
>
>What are the reasons to mandate 2.59/1.9?
>  
>
There was no perticular reason to mandate 2.59/1.9. Those were the 
versions on the developers' machines.

We just want to make sure anyone can build the system, irrespective of 
the version of auto tools (ideally run ./configure; make; make install;  
triple)

How can we find out the least common denominator. Any good references or 
guidelines?

Thanks,
Samisa...

>      Anuradha
>--
>http://anuradha-ratnaweera.blogspot.com
>http://www.linux.lk/~anuradha/
>
>  
>

Re: [Axis2] Dealing with different versions of automake/atoconf

Posted by Anuradha Ratnaweera <gn...@gmail.com>.

On 12/6/05, Samisa Abeysinghe <sa...@gmail.com> wrote:
>
> Given your expertise in the GNU make system, do you have any idea if
> we can make our configure.ac work across different versions of
> automake/autoconf?
>
> Basically the problem is that PHP uses autoconf 2.13 and automake
> 1.5 (PHP make system complains if the versions are not 2.13/1.5)
>
> Ours make use of autoconf 2.59 and automake 1.9 (our make system
> fails if versions are not 2.59/1.9)
>
> Can we write our configure.ac to work in these different version on
> auto tools?

I think the best option would be to find out the least common
denominator between the two different tools combination and remove the
version dependancy _completely_.  We don't have to be very much
backword compatible for anything earlier than 2.13/1.5.

What are the reasons to mandate 2.59/1.9?

      Anuradha
--
http://anuradha-ratnaweera.blogspot.com
http://www.linux.lk/~anuradha/

[Axis2] Dealing with different versions of automake/atoconf

Posted by Samisa Abeysinghe <sa...@gmail.com>.

Hi Anuradha,
    Given your expertise in the GNU make system, do you have any idea if 
we can make our configure.ac work across different versions of 
automake/autoconf?

    Basically the problem is that PHP uses autoconf 2.13 and automake 
1.5 (PHP make system complains if the versions are not 2.13/1.5)
    Ours make use of autoconf 2.59 and automake 1.9 (our make system 
fails if versions are not 2.59/1.9)

    Can we write our configure.ac to work in these different version on 
auto tools?

Thanks,
Samisa...

Re: [Axis2] memory leak fix in axis2_libxml2_writer_wrapper

Posted by Samisa Abeysinghe <sa...@gmail.com>.

Patch applied.
Thanks for the patch.

Samisa...

Sahan Gamage wrote:

> I have fixed a memory leak in the axis2_libxml2_writer_wrapper.c
> Please apply the following patch.
>
> - Sahan
>
>------------------------------------------------------------------------
>
>Index: parser/libxml2/src/axis2_libxml2_writer_wrapper.c
>===================================================================
>--- parser/libxml2/src/axis2_libxml2_writer_wrapper.c	(revision 354019)
>+++ parser/libxml2/src/axis2_libxml2_writer_wrapper.c	(working copy)
>@@ -541,6 +541,7 @@
>     AXIS2_FREE((*env)->allocator, writer_impl->qname_array.uri);
>     writer_impl->qname_array.prefix = NULL;
>     writer_impl->qname_array.prefix = NULL;
>+
>     
>     if(writer->ops)
>     {
>@@ -1390,11 +1391,14 @@
>                         strlen((const axis2_char_t*)(writer_impl->buffer->content))+1));
>             sprintf(output, 
>                     ((const axis2_char_t*)(writer_impl->buffer->content)));
>+    	    xmlBufferFree(writer_impl->buffer);
>+    	    writer_impl->buffer = NULL;
>         }
>     }
>     else if(writer_impl->writer_type == AXIS2_LIBXML2_WRITER_FILE)
>     {
>         printf(" This is not supported for this type of writer");
>     }
>+
>     return output;   
>-}
>\ No newline at end of file
>+}
>  
>

Re: [Axis2] more memory leak fixes

Posted by Samisa Abeysinghe <sa...@gmail.com>.

Patch applied.

This is fantastic: I get 0 leaks with vlagrind test using libxml:
==12913== LEAK SUMMARY:
==12913==    definitely lost: 0 bytes in 0 blocks.
==12913==      possibly lost: 0 bytes in 0 blocks.
==12913==    still reachable: 870 bytes in 20 blocks.
==12913==         suppressed: 0 bytes in 0 blocks

Many thanks for the patch.

Samisa...

Sahan Gamage wrote:

> Hi,
>
> I have fixed a memory leak in the axis2_om_element.c.
> Please apply the patch and commit the code.
>
> - Sahan
>
>------------------------------------------------------------------------
>
>Index: om/src/axis2_om_element.c
>===================================================================
>--- om/src/axis2_om_element.c	(revision 354357)
>+++ om/src/axis2_om_element.c	(working copy)
>@@ -318,6 +318,7 @@
>                     (axis2_om_namespace_t *) (ns), env),uri) == 0)
>             {
>               
>+		AXIS2_FREE ((*env)->allocator, hashindex);
>                 return (axis2_om_namespace_t *) (ns);
>             }
>         }
>@@ -428,6 +429,7 @@
>             if (AXIS2_STRCMP(AXIS2_OM_NAMESPACE_GET_URI(
>                     (axis2_om_namespace_t *)(ns), env), uri) == 0)
>             {
>+		AXIS2_FREE ((*env)->allocator, hash_index);
>                 return (axis2_om_namespace_t *) (ns);
>             }
>         }
>  
>

[Axis2] more memory leak fixes

Posted by Sahan Gamage <sa...@wso2.com>.

Hi,

I have fixed a memory leak in the axis2_om_element.c.
Please apply the patch and commit the code.

- Sahan

[Axis2] memory leak fix in axis2_libxml2_writer_wrapper

Posted by Sahan Gamage <sa...@wso2.com>.

I have fixed a memory leak in the axis2_libxml2_writer_wrapper.c
Please apply the following patch.

- Sahan