You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2016/06/16 12:42:47 UTC

[GitHub] flink pull request #2113: [FLINK-4082] Add Setting for enabling/disabling La...

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/2113

    [FLINK-4082] Add Setting for enabling/disabling LargeRecordHandler

    By default this is set to disabled because there are known issues when
    users specify a custom TypeInformation.
    
    R: @tillrohrmann (the `R:` is for review) I think you know how stuff should work there
    CC: @StephanEwen 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink large-record-handler/setting

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2113.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2113
    
----
commit 183e5ab32951ae0ee8392efd147936bb4711d966
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2016-06-16T12:39:23Z

    [FLINK-4082] Add Setting for enabling/disabling LargeRecordHandler
    
    By default this is set to disabled because there are known issues when
    users specify a custom TypeInformation.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2113: [FLINK-4082] Add Setting for enabling/disabling LargeReco...

Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:

    https://github.com/apache/flink/pull/2113
  
    Thanks! Looks good to merge. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2113: [FLINK-4082] Add Setting for enabling/disabling LargeReco...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2113
  
    @uce I addressed the comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2113: [FLINK-4082] Add Setting for enabling/disabling La...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:

    https://github.com/apache/flink/pull/2113


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2113: [FLINK-4082] Add Setting for enabling/disabling LargeReco...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/2113
  
    Nope, I forgot that. Thanks for spotting!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2113: [FLINK-4082] Add Setting for enabling/disabling LargeReco...

Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:

    https://github.com/apache/flink/pull/2113
  
    Changes look good, but did you skip the `CombiningUnilateralSortMerger` on purpose?
    
    It's hard to tell, because the `handleLargeRecords` argument was existing before your changes, but it was not configurable. The `CombiningUnilateralSortMerger` always sets `handleLargeRecords` to `true`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---