[GitHub] [superset] ad-m commented on pull request #18143: refactor: migrate ExploreResultsButton component to FC & tsx

[GitBox <gi...@apache.org>]

ad-m commented on pull request #18143:
URL: https://github.com/apache/superset/pull/18143#issuecomment-1020766160


   > @ad-m @AAfghahi `renderInvalidColumnMessage`, `renderTimeoutWarning`, `buildVizOptions` are not used anywhere. Should I remove them?
   
   I do not feel entitled to judge the issue of style in this project (I have too little experience in the project), but due tagging, I will express my opinion: dead code should be removed from the codebase, and besides, it is probably removed from bundles provided to the user by the Webpack.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org