You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/13 14:19:15 UTC
[GitHub] [flink-kubernetes-operator] bgeng777 opened a new pull request, #267: [FLINK-28025] Document the change of serviceAccount in upgrading doc of k8s opeator
bgeng777 opened a new pull request, #267:
URL: https://github.com/apache/flink-kubernetes-operator/pull/267
1. Add document of #204 in the `Operator Upgrade Process` to emphasize the change of default values when upgrading from 0.1.0 to 1.0.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #267: [FLINK-28025] Document the change of serviceAccount in upgrading doc of k8s opeator
Posted by GitBox <gi...@apache.org>.
gyfora merged PR #267:
URL: https://github.com/apache/flink-kubernetes-operator/pull/267
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #267: [FLINK-28025] Document the change of serviceAccount in upgrading doc of k8s opeator
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on code in PR #267:
URL: https://github.com/apache/flink-kubernetes-operator/pull/267#discussion_r896703915
##########
docs/content/docs/operations/upgrade.md:
##########
@@ -138,3 +138,9 @@ The following steps demonstrate the CRD upgrade process from `v1alpha1` to `v1be
Starting job 00000000000000000000000000000000 from savepoint /flink-data/savepoints/savepoint-000000-2f40a9c8e4b9/_metadat
```
+### Changes of default values of FlinkDeployment
+There are some changes or improvement of default values in the fields of the FlinkDeployment in `v1beta1`:
+1. Default value of `crd.spec.Resource#cpu` is `1.0`.
Review Comment:
IMO, it's better to use table format to document these default values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #267: [FLINK-28025] Document the change of serviceAccount in upgrading doc of k8s opeator
Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #267:
URL: https://github.com/apache/flink-kubernetes-operator/pull/267#discussion_r896726511
##########
docs/content/docs/operations/upgrade.md:
##########
@@ -138,3 +138,9 @@ The following steps demonstrate the CRD upgrade process from `v1alpha1` to `v1be
Starting job 00000000000000000000000000000000 from savepoint /flink-data/savepoints/savepoint-000000-2f40a9c8e4b9/_metadat
```
+### Changes of default values of FlinkDeployment
+There are some changes or improvement of default values in the fields of the FlinkDeployment in `v1beta1`:
+1. Default value of `crd.spec.Resource#cpu` is `1.0`.
Review Comment:
I think given that we have only 4 points here, we can keep it as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] SteNicholas commented on a diff in pull request #267: [FLINK-28025] Document the change of serviceAccount in upgrading doc of k8s opeator
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on code in PR #267:
URL: https://github.com/apache/flink-kubernetes-operator/pull/267#discussion_r896703915
##########
docs/content/docs/operations/upgrade.md:
##########
@@ -138,3 +138,9 @@ The following steps demonstrate the CRD upgrade process from `v1alpha1` to `v1be
Starting job 00000000000000000000000000000000 from savepoint /flink-data/savepoints/savepoint-000000-2f40a9c8e4b9/_metadat
```
+### Changes of default values of FlinkDeployment
+There are some changes or improvement of default values in the fields of the FlinkDeployment in `v1beta1`:
+1. Default value of `crd.spec.Resource#cpu` is `1.0`.
Review Comment:
IMO, this could use table format to document these default values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org