You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/23 06:26:10 UTC

[GitHub] [flink] zhijiangW opened a new pull request #8518: [FLINK-12564][network] Remove getBufferProvider method from ResultPartitionWriter

zhijiangW opened a new pull request #8518: [FLINK-12564][network] Remove getBufferProvider method from ResultPartitionWriter
URL: https://github.com/apache/flink/pull/8518
 
 
   ## What is the purpose of the change
   
   *`ResultPartitionWriter#getBufferProvider` seems not very general for all the writer implementations. So this method could be merged with `ResultPartitionWriter#addBufferConsumer` to refactor as `ResultPartitionWriter#requestBufferBuilder` which returns a `BufferBuilder` for writing data and the corresponding `BufferConsumer` is added into sub partition.*
   
   ## Brief change log
   
     - *Remove `getBufferProvider` from `ResultPartitionWriter`*
     - *Introduce `requestBufferBuilder` and `broadcastEvents` for `ResultPartitionWriter`*
     - *Refactor the process in `RecordWriter`*
   
   ## Verifying this change
   
   covered by existing tests
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services